-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update p_group_cohomology to GAP 4.10 #26901
Comments
This comment has been minimized.
This comment has been minimized.
comment:2
This is how far it gets on a Linux laptop within 30 minutes of wall clock time, if installed with
|
comment:3
At the moment, I am about to upgrade the cohomology package anyway. That's #26001. What isn't mentioned in the ticket description: I plan to replace gap-via-pexpect by libgap. Currently the work was stalled because of teaching, but I suppose that I will fix the package over the holidays. I propose that I first finish #26001 and then we can see if there are issues left with the gap upgrade. |
comment:4
I suggest that you base #26001 on #22626 (and #26856), or at least be prepared that they might make you do extra work if you stick with (lib)GAP 4.8.6 for the time being. In particular there are few (low-level) API changes for libGAP in Sage done in #22626. As well, perhaps more importantly, there is sometimes extra work to be done in porting to libGAP just because some parts of Sage are still pexpect-GAP based, in particular PermutationGroup (see e.g. #26889) for such an example. We should plan to take care of this soon, perhaps even before #26001 (but not before #22626 and #26856). |
comment:5
For the record, this is the full log of installation with SAGE_CHECK=yes
|
comment:6
By the way, I am pretty sure that the errors mentioned here are caused not by a new GAP version but by a new Singular version. My suggestion: I finish the upgrade on #26001 with the old GAP version. Then, if #22626 is done, we can still see if errors remain. If errors remain, then I will do another upgrade, using the ticket here. |
comment:7
OK, that's fine. |
comment:8
Let's see about doing this for 8.6 if possible; otherwise wait for 8.7. |
Reviewer: Simon King |
#26856 updates database_gap to GAP 4.10, and this requires changes in the package docs, as well as fixes of doctests (hopefully easy).
in particular, everything that mentions database_gap should disappear, as all the data there becomes a part of GAP spkg.
Depends on #26856
CC: @simon-king-jena
Component: packages: optional
Reviewer: Simon King
Issue created by migration from https://trac.sagemath.org/ticket/26901
The text was updated successfully, but these errors were encountered: