Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update p_group_cohomology to GAP 4.10 #26901

Closed
dimpase opened this issue Dec 15, 2018 · 11 comments
Closed

update p_group_cohomology to GAP 4.10 #26901

dimpase opened this issue Dec 15, 2018 · 11 comments

Comments

@dimpase
Copy link
Member

dimpase commented Dec 15, 2018

#26856 updates database_gap to GAP 4.10, and this requires changes in the package docs, as well as fixes of doctests (hopefully easy).

in particular, everything that mentions database_gap should disappear, as all the data there becomes a part of GAP spkg.

Depends on #26856

CC: @simon-king-jena

Component: packages: optional

Reviewer: Simon King

Issue created by migration from https://trac.sagemath.org/ticket/26901

@dimpase dimpase added this to the sage-8.5 milestone Dec 15, 2018
@dimpase
Copy link
Member Author

dimpase commented Dec 15, 2018

comment:1

As #22626 is still being worked on, there is a small chance of output and other changes in GAP behaviour, but I guess it's minimal. With the #26856 branch (at commit 90f2fea), the package builds and passes some, but not all, tests.

@dimpase

This comment has been minimized.

@dimpase
Copy link
Member Author

dimpase commented Dec 15, 2018

comment:2

This is how far it gets on a Linux laptop within 30 minutes of wall clock time, if installed with SAGE_CHECK=yes:

[p_group_cohomology-3.0] Running the test suite for p_group_cohomology-3.0...
[p_group_cohomology-3.0] make[2]: Entering directory '/mnt/opt/Sage/sage-dev/local/var/tmp/sage/build/p_group_cohomology-3.0/src/csources'
[p_group_cohomology-3.0] Making check in src
[p_group_cohomology-3.0] make[3]: Entering directory '/mnt/opt/Sage/sage-dev/local/var/tmp/sage/build/p_group_cohomology-3.0/src/csources/src'
[p_group_cohomology-3.0] make  mnttest.sh
[p_group_cohomology-3.0] make[4]: Entering directory '/mnt/opt/Sage/sage-dev/local/var/tmp/sage/build/p_group_cohomology-3.0/src/csources/src'
[p_group_cohomology-3.0] test -r ./test.reg || cp ./test.reg .
[p_group_cohomology-3.0] make[4]: Leaving directory '/mnt/opt/Sage/sage-dev/local/var/tmp/sage/build/p_group_cohomology-3.0/src/csources/src'
[p_group_cohomology-3.0] make  check-TESTS
[p_group_cohomology-3.0] make[4]: Entering directory '/mnt/opt/Sage/sage-dev/local/var/tmp/sage/build/p_group_cohomology-3.0/src/csources/src'
[p_group_cohomology-3.0] make[5]: Entering directory '/mnt/opt/Sage/sage-dev/local/var/tmp/sage/build/p_group_cohomology-3.0/src/csources/src'
[p_group_cohomology-3.0] PASS: mnttest.sh
[p_group_cohomology-3.0] ============================================================================
[p_group_cohomology-3.0] Testsuite summary for modular_resolution 1.0
[p_group_cohomology-3.0] ============================================================================
[p_group_cohomology-3.0] # TOTAL: 1
[p_group_cohomology-3.0] # PASS:  1
[p_group_cohomology-3.0] # SKIP:  0
[p_group_cohomology-3.0] # XFAIL: 0
[p_group_cohomology-3.0] # FAIL:  0
[p_group_cohomology-3.0] # XPASS: 0
[p_group_cohomology-3.0] # ERROR: 0
[p_group_cohomology-3.0] ============================================================================
[p_group_cohomology-3.0] make[5]: Leaving directory '/mnt/opt/Sage/sage-dev/local/var/tmp/sage/build/p_group_cohomology-3.0/src/csources/src'
[p_group_cohomology-3.0] make[4]: Leaving directory '/mnt/opt/Sage/sage-dev/local/var/tmp/sage/build/p_group_cohomology-3.0/src/csources/src'
[p_group_cohomology-3.0] make[3]: Leaving directory '/mnt/opt/Sage/sage-dev/local/var/tmp/sage/build/p_group_cohomology-3.0/src/csources/src'
[p_group_cohomology-3.0] make[3]: Entering directory '/mnt/opt/Sage/sage-dev/local/var/tmp/sage/build/p_group_cohomology-3.0/src/csources'
[p_group_cohomology-3.0] make[3]: Leaving directory '/mnt/opt/Sage/sage-dev/local/var/tmp/sage/build/p_group_cohomology-3.0/src/csources'
[p_group_cohomology-3.0] make[2]: Leaving directory '/mnt/opt/Sage/sage-dev/local/var/tmp/sage/build/p_group_cohomology-3.0/src/csources'
[p_group_cohomology-3.0] too many failed tests, not using stored timings
[p_group_cohomology-3.0] Running doctests with ID 2018-12-15-12-28-22-11b32805.
[p_group_cohomology-3.0] Git branch: HEAD
[p_group_cohomology-3.0] Using --optional=dochtml,fricas,gdb,meataxe,memlimit,mpir,python2,sage
[p_group_cohomology-3.0] Sorting sources by runtime so that slower doctests are run first....
[p_group_cohomology-3.0] Doctesting 12 files using 4 threads.
[p_group_cohomology-3.0] sage -t --long pyxsources/pGroupCohomology/cochain.pxd
[p_group_cohomology-3.0]     [0 tests, 0.00 s]
[p_group_cohomology-3.0] sage -t --long pyxsources/pGroupCohomology/auxiliaries.py
[p_group_cohomology-3.0]     [69 tests, 5.86 s]
[p_group_cohomology-3.0] sage -t --long pyxsources/pGroupCohomology/cochain.pyx
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/cochain.pyx", line 93, in pGroupCohomology.cochain
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     cS1 = HS.1*HS.2+HS.3; cS1
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     (c_2_1)*(c_1_0)+(b_3_2): 3-Cocycle in H^*(Sym6; GF(2))
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     (c_2_1)*(c_1_0)+(b_3_3): 3-Cocycle in H^*(Sym6; GF(2))
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/cochain.pyx", line 95, in pGroupCohomology.cochain
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     cS2 = HS.1*HS.2+HS.4; cS2
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     (c_2_1)*(c_1_0)+(c_3_3): 3-Cocycle in H^*(Sym6; GF(2))
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     (c_2_1)*(c_1_0)+(c_3_2): 3-Cocycle in H^*(Sym6; GF(2))
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/cochain.pyx", line 99, in pGroupCohomology.cochain
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     HS.rels()
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     ['b_3_2^2+b_3_2*c_3_3+c_2_1*c_1_0*b_3_2']
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     ['b_3_3*c_3_2+c_2_1*c_1_0*b_3_3']
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/cochain.pyx", line 107, in pGroupCohomology.cochain
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     [resS_D(g).as_polynomial() for g in HS.gens()[1:]]
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     ['c_2_2', 'b_1_1+b_1_0', 'c_2_2*b_1_1+c_2_2*b_1_0', 'b_1_0^2*b_1_1+c_2_2*b_1_1']
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     ['c_2_2', 'b_1_1+b_1_0', 'b_1_0^2*b_1_1+c_2_2*b_1_1', '0']
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/cochain.pyx", line 125, in pGroupCohomology.cochain
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     HD.1*resS_D(HS.2) == resS_D(HS.1)*(HD.2+HD.3) == resS_D(HS.3)
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     True
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     False

@simon-king-jena
Copy link
Member

comment:3

At the moment, I am about to upgrade the cohomology package anyway. That's #26001. What isn't mentioned in the ticket description: I plan to replace gap-via-pexpect by libgap. Currently the work was stalled because of teaching, but I suppose that I will fix the package over the holidays.

I propose that I first finish #26001 and then we can see if there are issues left with the gap upgrade.

@dimpase
Copy link
Member Author

dimpase commented Dec 15, 2018

comment:4

I suggest that you base #26001 on #22626 (and #26856), or at least be prepared that they might make you do extra work if you stick with (lib)GAP 4.8.6 for the time being. In particular there are few (low-level) API changes for libGAP in Sage done in #22626.

As well, perhaps more importantly, there is sometimes extra work to be done in porting to libGAP just because some parts of Sage are still pexpect-GAP based, in particular PermutationGroup (see e.g. #26889) for such an example.

We should plan to take care of this soon, perhaps even before #26001 (but not before #22626 and #26856).

@dimpase
Copy link
Member Author

dimpase commented Dec 15, 2018

comment:5

For the record, this is the full log of installation with SAGE_CHECK=yes
Seems to be that most of it just formatting (with few places where GAP actually seems
be do doing better job than before):

[p_group_cohomology-3.0] Doctesting 12 files using 4 threads.
[p_group_cohomology-3.0] sage -t --long pyxsources/pGroupCohomology/cochain.pxd
[p_group_cohomology-3.0]     [0 tests, 0.00 s]
[p_group_cohomology-3.0] sage -t --long pyxsources/pGroupCohomology/auxiliaries.py
[p_group_cohomology-3.0]     [69 tests, 5.86 s]
[p_group_cohomology-3.0] sage -t --long pyxsources/pGroupCohomology/cochain.pyx
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/cochain.pyx", line 93, in pGroupCohomology.cochain
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     cS1 = HS.1*HS.2+HS.3; cS1
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     (c_2_1)*(c_1_0)+(b_3_2): 3-Cocycle in H^*(Sym6; GF(2))
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     (c_2_1)*(c_1_0)+(b_3_3): 3-Cocycle in H^*(Sym6; GF(2))
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/cochain.pyx", line 95, in pGroupCohomology.cochain
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     cS2 = HS.1*HS.2+HS.4; cS2
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     (c_2_1)*(c_1_0)+(c_3_3): 3-Cocycle in H^*(Sym6; GF(2))
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     (c_2_1)*(c_1_0)+(c_3_2): 3-Cocycle in H^*(Sym6; GF(2))
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/cochain.pyx", line 99, in pGroupCohomology.cochain
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     HS.rels()
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     ['b_3_2^2+b_3_2*c_3_3+c_2_1*c_1_0*b_3_2']
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     ['b_3_3*c_3_2+c_2_1*c_1_0*b_3_3']
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/cochain.pyx", line 107, in pGroupCohomology.cochain
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     [resS_D(g).as_polynomial() for g in HS.gens()[1:]]
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     ['c_2_2', 'b_1_1+b_1_0', 'c_2_2*b_1_1+c_2_2*b_1_0', 'b_1_0^2*b_1_1+c_2_2*b_1_1']
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     ['c_2_2', 'b_1_1+b_1_0', 'b_1_0^2*b_1_1+c_2_2*b_1_1', '0']
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/cochain.pyx", line 125, in pGroupCohomology.cochain
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     HD.1*resS_D(HS.2) == resS_D(HS.1)*(HD.2+HD.3) == resS_D(HS.3)
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     True
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     False
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/cochain.pyx", line 2728, in pGroupCohomology.cochain.MODCOCH.as_cocycle_in_subgroup
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     H.1.as_cocycle_in_subgroup()
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     (b_1_0)^2+(b_2_2)+(b_2_1): 2-Cocycle in H^*(SmallGroup(192,1493); GF(2))
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     b_2_1+(b_2_0): 2-Cocycle in H^*(SmallGroup(192,1493); GF(2))
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/cochain.pyx", line 2730, in pGroupCohomology.cochain.MODCOCH.as_cocycle_in_subgroup
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     H.subgroup_cohomology()('b_1_0^2+b_2_1+b_2_2')*H.2.as_cocycle_in_subgroup() == (H.1*H.2).as_cocycle_in_subgroup()
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     True
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     False
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/cochain.pyx", line 2774, in pGroupCohomology.cochain.MODCOCH.as_cocycle_in_sylow
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     H.1.as_cocycle_in_sylow()
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     b_1_1*b_1_2+b_1_1^2+b_1_0^2+b_2_5+b_2_4: 2-Cocycle in H^*(SmallGroup(64,138); GF(2))
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     b_1_2^2+b_1_1*b_1_2+b_2_6+b_2_5: 2-Cocycle in H^*(SmallGroup(64,138); GF(2))
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/cochain.pyx", line 2776, in pGroupCohomology.cochain.MODCOCH.as_cocycle_in_sylow
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     H.sylow_cohomology()('b_1_1*b_1_2+b_1_1^2+b_1_0^2+b_2_5+b_2_4')*H.2.as_cocycle_in_sylow() == (H.1*H.2).as_cocycle_in_sylow()
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     True
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     False
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] 3 items had failures:
[p_group_cohomology-3.0]    5 of  25 in pGroupCohomology.cochain
[p_group_cohomology-3.0]    2 of   9 in pGroupCohomology.cochain.MODCOCH.as_cocycle_in_subgroup
[p_group_cohomology-3.0]    2 of   8 in pGroupCohomology.cochain.MODCOCH.as_cocycle_in_sylow
[p_group_cohomology-3.0]     [1459 tests, 9 failures, 3379.55 s]
[p_group_cohomology-3.0] sage -t --long pyxsources/pGroupCohomology/barcode.py
[p_group_cohomology-3.0]     [143 tests, 114.92 s]
[p_group_cohomology-3.0] sage -t --long pyxsources/pGroupCohomology/dickson.pyx
[p_group_cohomology-3.0]     [28 tests, 2.66 s]
[p_group_cohomology-3.0] sage -t --long pyxsources/pGroupCohomology/factory.py
[p_group_cohomology-3.0]     [216 tests, 401.69 s]
[p_group_cohomology-3.0] sage -t --long pyxsources/pGroupCohomology/__init__.py
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/__init__.py", line 372, in pGroupCohomology
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     print(HS6b)
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     <BLANKLINE>
[p_group_cohomology-3.0]     Cohomology ring of SymmetricGroup(6) with coefficients in GF(2)
[p_group_cohomology-3.0]     <BLANKLINE>
[p_group_cohomology-3.0]     Computation complete
[p_group_cohomology-3.0]     Minimal list of generators:
[p_group_cohomology-3.0]     [c_2_1: 2-Cocycle in H^*(SymmetricGroup(6); GF(2)),
[p_group_cohomology-3.0]      c_1_0: 1-Cocycle in H^*(SymmetricGroup(6); GF(2)),
[p_group_cohomology-3.0]      b_3_2: 3-Cocycle in H^*(SymmetricGroup(6); GF(2)),
[p_group_cohomology-3.0]      c_3_3: 3-Cocycle in H^*(SymmetricGroup(6); GF(2))]
[p_group_cohomology-3.0]     Minimal list of algebraic relations:
[p_group_cohomology-3.0]     [b_3_2^2+b_3_2*c_3_3+c_2_1*c_1_0*b_3_2]
[p_group_cohomology-3.0]     <BLANKLINE>
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     <BLANKLINE>
[p_group_cohomology-3.0]     Cohomology ring of SymmetricGroup(6) with coefficients in GF(2)
[p_group_cohomology-3.0]     <BLANKLINE>
[p_group_cohomology-3.0]     Computation complete
[p_group_cohomology-3.0]     Minimal list of generators:
[p_group_cohomology-3.0]     [c_2_1: 2-Cocycle in H^*(SymmetricGroup(6); GF(2)),
[p_group_cohomology-3.0]      c_1_0: 1-Cocycle in H^*(SymmetricGroup(6); GF(2)),
[p_group_cohomology-3.0]      b_3_3: 3-Cocycle in H^*(SymmetricGroup(6); GF(2)),
[p_group_cohomology-3.0]      c_3_2: 3-Cocycle in H^*(SymmetricGroup(6); GF(2))]
[p_group_cohomology-3.0]     Minimal list of algebraic relations:
[p_group_cohomology-3.0]     [b_3_3*c_3_2+c_2_1*c_1_0*b_3_3]
[p_group_cohomology-3.0]     <BLANKLINE>
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/__init__.py", line 589, in pGroupCohomology
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     HS6a.subgroup()
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     Group( [ (1,3)(2,5), (1,2), (4,6), (1,2)(3,5) ] )
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     Group( [ (2,3)(4,6), (1,2)(3,5)(4,6), (1,5)(2,3)(4,6), (1,5)(2,3) ] )
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/__init__.py", line 591, in pGroupCohomology
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     HS6a.sylow_subgroup()
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     Group( [ (1,3)(2,5), (1,2), (4,6) ] )
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     Group( [ (2,3)(4,6), (1,2)(3,5)(4,6), (1,5)(2,3)(4,6) ] )
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/__init__.py", line 601, in pGroupCohomology
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     [H0.element_as_polynomial(phi_star(x)) for x in HS6a.gens()]
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     [1: 0-Cocycle in H^*(D8; GF(2)),
[p_group_cohomology-3.0]      b_1_1^2+c_2_2: 2-Cocycle in H^*(D8; GF(2)),
[p_group_cohomology-3.0]      b_1_0: 1-Cocycle in H^*(D8; GF(2)),
[p_group_cohomology-3.0]      c_2_2*b_1_1: 3-Cocycle in H^*(D8; GF(2)),
[p_group_cohomology-3.0]      0: 3-Cocycle in H^*(D8; GF(2))]
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     [1: 0-Cocycle in H^*(D8; GF(2)),
[p_group_cohomology-3.0]      b_1_1^2+b_1_0^2+c_2_2: 2-Cocycle in H^*(D8; GF(2)),
[p_group_cohomology-3.0]      b_1_0: 1-Cocycle in H^*(D8; GF(2)),
[p_group_cohomology-3.0]      c_2_2*b_1_0: 3-Cocycle in H^*(D8; GF(2)),
[p_group_cohomology-3.0]      b_1_0^3+c_2_2*b_1_1+c_2_2*b_1_0: 3-Cocycle in H^*(D8; GF(2))]
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/__init__.py", line 608, in pGroupCohomology
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     singular(phi_star)
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     s...[1]=b_1_1^2+c_2_2
[p_group_cohomology-3.0]     s...[2]=b_1_0
[p_group_cohomology-3.0]     s...[3]=c_2_2*b_1_1
[p_group_cohomology-3.0]     s...[4]=0
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     sage5014[1]=b_1_1^2+b_1_0^2+c_2_2
[p_group_cohomology-3.0]     sage5014[2]=b_1_0
[p_group_cohomology-3.0]     sage5014[3]=c_2_2*b_1_0
[p_group_cohomology-3.0]     sage5014[4]=b_1_0^3+c_2_2*b_1_1+c_2_2*b_1_0
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/__init__.py", line 616, in pGroupCohomology
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     phi_star.preimage()
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     c_3_2,
[p_group_cohomology-3.0]     c_1_0*b_3_3
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     b_3_3+c_2_1*c_1_0+c_1_0^3,
[p_group_cohomology-3.0]     c_1_0*c_3_2+c_2_1*c_1_0^2
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/__init__.py", line 619, in pGroupCohomology
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     phi_star(HS6a('c_3_2')).as_polynomial()
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     '0'
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     'b_1_0^3+c_2_2*b_1_1+c_2_2*b_1_0'
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/__init__.py", line 621, in pGroupCohomology
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     phi_star(HS6a('c_1_0*b_3_3')).as_polynomial()
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     '0'
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     'c_2_2*b_1_0^2'
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/__init__.py", line 2410, in pGroupCohomology
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     H.parameters()
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     ['b_2_1^2+c_4_0',
[p_group_cohomology-3.0]      'b_3_1^2+b_3_0^2+b_2_1*c_4_0',
[p_group_cohomology-3.0]      'b_7_18+b_2_1*b_5_0+c_4_0*b_3_1+c_4_0*b_3_0',
[p_group_cohomology-3.0]      'b_1_0^6+b_6_0']
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     ['b_2_0^2+c_4_0',
[p_group_cohomology-3.0]      'b_3_1^2+b_3_0^2+b_2_0*c_4_0',
[p_group_cohomology-3.0]      'b_7_18+b_2_0*b_5_0+c_4_0*b_3_1',
[p_group_cohomology-3.0]      'b_1_0^6+b_6_0']
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/__init__.py", line 2419, in pGroupCohomology
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     H.dependent_parameters()
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     ['b_1_0', 'b_7_18', 'b_6_0', 'c_4_0', 'b_3_0', 'b_3_1', 'b_2_1']
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     ['b_1_0', 'b_7_18', 'b_6_0', 'c_4_0', 'b_3_0', 'b_3_1', 'b_2_0']
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/__init__.py", line 2449, in pGroupCohomology
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     H._parameters_for_criterion
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     ['b_1_0', 'b_7_18', 'b_6_0', 'c_4_0', 'b_3_0', 'b_3_1', 'b_2_1']
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     ['b_1_0', 'b_7_18', 'b_6_0', 'c_4_0', 'b_3_0', 'b_3_1', 'b_2_0']
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] 1 item had failures:
[p_group_cohomology-3.0]   11 of 350 in pGroupCohomology
[p_group_cohomology-3.0]     [349 tests, 11 failures, 1085.17 s]
[p_group_cohomology-3.0] sage -t --long pyxsources/pGroupCohomology/resolution.pyx
[p_group_cohomology-3.0]     [882 tests, 49.19 s]
[p_group_cohomology-3.0] sage -t --long pyxsources/pGroupCohomology/resolution.pxd
[p_group_cohomology-3.0]     [0 tests, 0.00 s]
[p_group_cohomology-3.0] sage -t --long pyxsources/pGroupCohomology/resolution_bindings.pxd
[p_group_cohomology-3.0]     [0 tests, 0.00 s]
[p_group_cohomology-3.0] sage -t --long pyxsources/pGroupCohomology/modular_cohomology.pyx
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/modular_cohomology.pyx", line 123, in pGroupCohomology.modular_cohomology._IdGroup
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     _IdGroup(G1,D,H, ring=False)
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     Failed to construct a minimal generating set of the group -- keep your fingers crossed...
[p_group_cohomology-3.0]     (2520, 0)
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     (2520, 0)
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/modular_cohomology.pyx", line 142, in pGroupCohomology.modular_cohomology._IdGroup
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     _IdGroup(G1,D,H, ring=False)
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     Failed to construct a minimal generating set of the group -- keep your fingers crossed...
[p_group_cohomology-3.0]     (2520, -1)
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     (2520, -1)
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] 1 item had failures:
[p_group_cohomology-3.0]    2 of  19 in pGroupCohomology.modular_cohomology._IdGroup
[p_group_cohomology-3.0]     [450 tests, 2 failures, 1735.11 s]
[p_group_cohomology-3.0] sage -t --long pyxsources/pGroupCohomology/cohomology.pyx
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/cohomology.pyx", line 8021, in pGroupCohomology.cohomology.COHO.filter_regular_parameters
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     H.duflot_regular_sequence()
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     ['c_4_1']
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     ['c_4_0']
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/cohomology.pyx", line 8031, in pGroupCohomology.cohomology.COHO.filter_regular_parameters
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     H.filter_regular_parameters()
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     ['b_3_1*b_5_2+b_2_0^4+c_4_1^2',
[p_group_cohomology-3.0]      'b_3_1^4+b_3_0^4+b_6_2*b_3_1^2+b_6_2^2+b_2_0^3*b_6_2+c_4_1*b_3_1*b_5_2+b_2_0*c_4_1*b_3_1^2+b_2_0^2*c_4_1^2',
[p_group_cohomology-3.0]      'b_7_6^2+b_3_1^3*b_5_2+b_6_2*b_3_1*b_5_2+b_2_0*b_6_2*b_3_1^2+b_2_0^3*b_3_1*b_5_2+b_2_0^4*b_6_2+b_2_0^2*c_4_1*b_3_1^2+b_2_0^2*c_4_1*b_6_2+c_4_1^2*b_3_0^2',
[p_group_cohomology-3.0]      'b_6_2']
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     ['b_3_1*b_5_0+b_2_0^4+c_4_0^2',
[p_group_cohomology-3.0]      'b_6_2^2+b_6_0*b_6_2+b_6_0^2+b_2_0^2*b_3_1*b_5_0',
[p_group_cohomology-3.0]      'b_7_4^2+b_3_1^3*b_5_0+b_6_0*b_3_1*b_5_0+b_2_0*b_6_0*b_3_1^2+b_2_0^3*b_3_1*b_5_0+b_2_0^4*b_6_0+b_2_0^2*c_4_0*b_3_1^2+b_2_0^2*c_4_0*b_6_0+c_4_0^2*b_3_0^2',
[p_group_cohomology-3.0]      'b_3_1^3+b_2_0^2*b_5_0']
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] File "pyxsources/pGroupCohomology/cohomology.pyx", line 8846, in pGroupCohomology.cohomology.COHO.parameters
[p_group_cohomology-3.0] Failed example:
[p_group_cohomology-3.0]     H.parameters()
[p_group_cohomology-3.0] Expected:
[p_group_cohomology-3.0]     ['b_2_0^2+c_4_1',
[p_group_cohomology-3.0]      'b_3_1^4+b_3_0^4+b_6_2*b_3_1^2+b_6_2^2+b_2_0^3*b_6_2+c_4_1*b_3_1*b_5_2+b_2_0*c_4_1*b_3_1^2+b_2_0^2*c_4_1^2',
[p_group_cohomology-3.0]      'b_7_6+c_4_1*b_3_1+c_4_1*b_3_0',
[p_group_cohomology-3.0]      'b_6_2']
[p_group_cohomology-3.0] Got:
[p_group_cohomology-3.0]     ['b_2_0^2+c_4_0',
[p_group_cohomology-3.0]      'b_3_1^2+b_3_0^2+b_2_0*c_4_0',
[p_group_cohomology-3.0]      'b_7_4+b_2_0*b_5_0+c_4_0*b_3_0',
[p_group_cohomology-3.0]      'b_6_0']
[p_group_cohomology-3.0] **********************************************************************
[p_group_cohomology-3.0] 2 items had failures:
[p_group_cohomology-3.0]    2 of  16 in pGroupCohomology.cohomology.COHO.filter_regular_parameters
[p_group_cohomology-3.0]    1 of  15 in pGroupCohomology.cohomology.COHO.parameters
[p_group_cohomology-3.0]     [1371 tests, 3 failures, 2275.69 s]
[p_group_cohomology-3.0] ----------------------------------------------------------------------
[p_group_cohomology-3.0] sage -t --long pyxsources/pGroupCohomology/cochain.pyx  # 9 doctests failed
[p_group_cohomology-3.0] sage -t --long pyxsources/pGroupCohomology/__init__.py  # 11 doctests failed
[p_group_cohomology-3.0] sage -t --long pyxsources/pGroupCohomology/modular_cohomology.pyx  # 2 doctests failed
[p_group_cohomology-3.0] sage -t --long pyxsources/pGroupCohomology/cohomology.pyx  # 3 doctests failed
[p_group_cohomology-3.0] ----------------------------------------------------------------------
[p_group_cohomology-3.0] Total time for all tests: 3380.8 seconds
[p_group_cohomology-3.0]     cpu time: 8057.3 seconds
[p_group_cohomology-3.0]     cumulative wall time: 9049.9 seconds
[p_group_cohomology-3.0] ********************************************************************************
[p_group_cohomology-3.0] Error testing pGroupCohomology
[p_group_cohomology-3.0] ********************************************************************************
[p_group_cohomology-3.0] 
[p_group_cohomology-3.0] real	56m26.483s
[p_group_cohomology-3.0] user	71m56.006s
[p_group_cohomology-3.0] sys	66m52.764s

@simon-king-jena
Copy link
Member

comment:6

By the way, I am pretty sure that the errors mentioned here are caused not by a new GAP version but by a new Singular version.

My suggestion: I finish the upgrade on #26001 with the old GAP version. Then, if #22626 is done, we can still see if errors remain. If errors remain, then I will do another upgrade, using the ticket here.

@dimpase
Copy link
Member Author

dimpase commented Dec 15, 2018

comment:7

OK, that's fine.

@embray
Copy link
Contributor

embray commented Dec 28, 2018

comment:8

Let's see about doing this for 8.6 if possible; otherwise wait for 8.7.

@embray embray modified the milestones: sage-8.5, sage-8.6 Dec 28, 2018
@simon-king-jena
Copy link
Member

comment:9

Replying to @embray:

Let's see about doing this for 8.6 if possible; otherwise wait for 8.7.

GAP 4.10 already is in the current develop branch. My current attempts to fix #26001 are based on the current develop branch. Corollary: #26001 supersedes this ticket.

Hence: Close as duplicate.

@simon-king-jena
Copy link
Member

Reviewer: Simon King

@simon-king-jena simon-king-jena removed this from the sage-8.6 milestone Dec 28, 2018
@embray embray closed this as completed Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants