spkg-configure.m4 for mpc

[dimpase]

mpc depends on GMP/MPIR and MPFR.
I am trying something like this:

SAGE_SPKG_CONFIGURE([mpc], [
    AC_CHECK_HEADER(mpc.h, [], [sage_spkg_install_mpc=yes])
dnl mpc_cmp_abs appeared in MPC 1.1.0
    AC_SEARCH_LIBS([mpc_cmp_abs], [mpc], [break], [sage_spkg_install_mpc=yes])
])

to be merged as a part of #27822

Depends on #27212
Depends on #27258

CC: @embray

Component: build: configure

Keywords: spkg-configure mpc

Author: Dima Pasechnik, Erik Bray

Branch: d15ead5

Reviewer: Erik Bray, Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/27259

[dimpase]

comment:1

mpfrcx's spkg-install hardcodes the location of mpc to SAGE_LOCAL. So this will need to be fixed.

[embray]

comment:2

That should be no problem (in theory). We'll treat the prefix for mpc similarly to how we've done with GMP.

[dimpase]

Branch: u/dimpase/packages/mpc-config

[dimpase]

Last 10 new commits:

b070088	Move all the --with-mp logic into the spkg-configure.m4 for MPIR so that it
3b6eebd	Replace various --with-gmp=$SAGE_LOCAL flags in spkg-installs with a
b80bf72	Reworked this a bit more
0ca3f56	fix typo
06798ca	added a bit more explanation
b592d77	correct logic for SAGE_GMP_PREFIX etc
5057680	add the AX_ABSOLUTE_HEADER macro
101537b	iml in particular is very picky about being given an absolute path to the
5e1a30b	spkg-configure for mpfr, adjustments for its dependees
db992be	spkg-configure for mpc, adjustments for its dependees

[dimpase]

Commit: db992be

[sagetrac-git]

Changed commit from db992be to 38427e1

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

18fbf7b	add SAGE_CONFIGURE_MPFR, fix sage-env-config.in
50aebab	implement --with-mpfr=system/install
38427e1	spkg-configure for mpc, adjustments for its dependees

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

862ca6a	Merge remote-tracking branch 'trac/develop' into HEAD
03dc987	Merged trac #27215 in
c9873ae	Merge remote-tracking branch 'trac/develop' into mpf
0fc433f	update for Sage 8.7.rc0, a typo fix
ec32471	Merge branch 'u/dimpase/packages/mpc-config' of trac.sagemath.org:sage into mpf
91f423f	rebase, deal with --with-mpc

[sagetrac-git]

Changed commit from 38427e1 to 91f423f

[dimpase]

New commits:

862ca6a	Merge remote-tracking branch 'trac/develop' into HEAD
03dc987	Merged trac #27215 in
c9873ae	Merge remote-tracking branch 'trac/develop' into mpf
0fc433f	update for Sage 8.7.rc0, a typo fix
ec32471	Merge branch 'u/dimpase/packages/mpc-config' of trac.sagemath.org:sage into mpf
91f423f	rebase, deal with --with-mpc

[embray]

comment:7

Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0b72a68	spkg-configure for mpfr, adjustments for its dependees
d690c9f	add SAGE_CONFIGURE_MPFR, fix sage-env-config.in
a833f93	implement --with-mpfr=system/install
62feae3	build mpir if gmp/mpir is built
df8e63d	bumped up configure
bfac833	spkg-configure for mpc, adjustments for its dependees
f41aab4	rebase, deal with --with-mpc

[sagetrac-git]

Changed commit from 91f423f to f41aab4

[embray]

Changed branch from u/dimpase/packages/mpc-config to public/packages/mpc-config

[embray]

comment:9

Rebased on latest #27258.

Confirmed that Sage built successfully on Ubuntu 18.04 with system gmp+mpfr+mpc among other packages. Running the tests now but they all passed in #27258, so I would be surprised if that changed here.

---

New commits:

d9bbdd4	Add support for unconditional pre- and post-check actions in spkg-configure.m4
a360518	Refactor the mpir/spkg-configure.m4 (and to a lesser extent the one for gmp) to use the new pre and post arguments to SAGE_SPKG_CONFIGURE
d5986af	spkg-configure for mpfr, adjustments for its dependees
1948e33	Add one missing SAGE_CONFIGURE_MPFR, for building gcc
16b907a	spkg-configure for mpc, adjustments for its dependees
0c906f1	rebase, deal with --with-mpc
5372ee0	Clean up spkg-configure.m4 for mpc to follow the current model for mpc
428dfab	Use SAGE_CONFIGURE_MPC for building gcc
953ba02	Add missing AC_MSG_RESULT

[embray]

Changed commit from f41aab4 to 953ba02

[embray]

comment:10

Tests pass, so, LGTM. Would you like to test more on other systems or are you already generally satisfied with how this is?

[dimpase]

comment:11

I'll run tests on OSX and if all is good, set it and the mpfr tickets to positive reviews. Thanks!

[embray]

comment:12

And then we'll add a separate ticket just for a new confball?

[embray]

Changed keywords from none to spkg-configure mpc

[dimpase]

comment:14

how about adding config tarball here?

or perhaps we can proceed rebasing nil/flint/arb over this one (we should do this one way or another) and add a config tarball on arb's ticket?

[embray]

comment:17

Rebased and squashed.

[sagetrac-git]

Changed commit from b63bc91 to d15ead5

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:

d5e5e3d	spkg-configure for mpfr, adjustments for its dependees
0329fd9	Add one missing SAGE_CONFIGURE_MPFR, for building gcc
d15ead5	Trac #27259: spkg-configure for mpc, adjustments for its dependents

[embray]

comment:19

Rebased again, but specifically over the branch for #27258.

[embray]

comment:20

This ticket should probably not be merged by itself. Instead please merge #27822 which incorporates this one.

[vbraun]

Changed branch from public/packages/mpc-config to d15ead5

[vbraun]

Changed commit from d15ead5 to none