Patch pynac to build properly with Cygwin's system GMP

[embray]

There are some bits in plain GMP not present for some reason in MPIR such that Cygwin gets some configure-time flags set differently than the defaults on Linux. Cygwin's system package for GMP is configured with these different defaults, leading to a build failure in pynac that I don't get on other platforms.

See the upstream PR for more details: pynac/pynac#342

Upstream: Fixed upstream, but not in a stable release.

Component: porting: Cygwin

Keywords: gmp pynac

Author: Erik Bray

Branch: 5816c4b

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27713

[embray]

Author: Erik Bray

[embray]

Branch: u/embray/cygwin/build/ticket-27713

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

5816c4b

Trac #27713: Include patch to pynac to fix build issue when using Cygwin's system GMP

[sagetrac-git]

Commit: 5816c4b

[embray]

comment:3

To add, this started of course since #27212. Not sure why I didn't catch the problem before since I have recollection of testing this on Cygwin, but maybe I just never rebuilt everything (including pynac?) from scratch for some reason.

[embray]

Changed upstream from Reported upstream. No feedback yet. to Fixed upstream, but not in a stable release.

[embray]

comment:4

Fixed upstream. rws confirms there will be a new pynac release in a few weeks, so we can possibly wait on that as well.

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:5

I think we can add this patch now (in part to get some extra testing through Sage beta releases) and then remove it when we upgrade Pynac (if that does get into the next stable Sage release).

[vbraun]

Changed branch from u/embray/cygwin/build/ticket-27713 to 5816c4b

[dimpase]

comment:7

the update with the patch in has been released, see #28016

[dimpase]

Changed commit from 5816c4b to none