Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matplotlib 2.2.4 + patches #28023

Closed
jdemeyer opened this issue Jun 20, 2019 · 15 comments
Closed

matplotlib 2.2.4 + patches #28023

jdemeyer opened this issue Jun 20, 2019 · 15 comments

Comments

@jdemeyer
Copy link

Upgrade to matplotlib 2.2.4

Tarball: http://sage.ugent.be/www/jdemeyer/sage/matplotlib-2.2.4.tar.bz2

We add two patches:

CC: @timokau

Component: packages: standard

Author: Jeroen Demeyer

Branch/Commit: 296092e

Reviewer: Vincent Klein

Issue created by migration from https://trac.sagemath.org/ticket/28023

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

Branch: u/jdemeyer/t/28023

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 20, 2019

Commit: 175a034

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 20, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

175a034matplotlib 2.2.4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 20, 2019

Changed commit from 175a034 to 296092e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 20, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

296092ematplotlib 2.2.4

@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer changed the title matplotlib 2.2.4 + setup.py patch matplotlib 2.2.4 + patches Jun 20, 2019
@jdemeyer
Copy link
Author

jdemeyer commented Jul 8, 2019

comment:9

Both patches affect only the build, so should be OK for distros.

@vinklein
Copy link
Mannequin

vinklein mannequin commented Jul 26, 2019

comment:10

Saying this ticket apply PR#14582 is inaccurate because there is only one of the two commits of this PR in
python38.patch. 4b957fd is present but not d94433. Is it intended ?

@vinklein
Copy link
Mannequin

vinklein mannequin commented Jul 26, 2019

comment:11

Tests pass with py3 for the sage files using matplolib. sage -t -a --long in progress for py2.

@vinklein
Copy link
Mannequin

vinklein mannequin commented Jul 29, 2019

comment:12

All tests pass in py2.

@vinklein
Copy link
Mannequin

vinklein mannequin commented Jul 29, 2019

Reviewer: Vincent Klein

@vinklein
Copy link
Mannequin

vinklein mannequin commented Jul 29, 2019

comment:13

Since d94433 has nothing to do with python3.8 compatibility i set this ticket to positive review.

@vbraun
Copy link
Member

vbraun commented Aug 1, 2019

Changed branch from u/jdemeyer/t/28023 to 296092e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants