Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build binder compatible docker images from Trac #28457

Closed
saraedum opened this issue Sep 5, 2019 · 13 comments
Closed

Build binder compatible docker images from Trac #28457

saraedum opened this issue Sep 5, 2019 · 13 comments
Labels
c: docker p: major / 3 t: enhancement
Milestone
sage-9.2

Comments

@saraedum
Copy link
Member

saraedum commented Sep 5, 2019

By tagging all our images with the commit SHA in GitLab registry.

You cannot sanely create a binder that points to a moving target such as a branch. Therefore, all images need to have unique tags.

With the changes merged, links like this should work for all branches on trac:

https://gitlab-hooks-flau3jeaza-ew.a.run.app/status/trac/branch/u%2Fsaraedum%2F28457

Depends on #28041

CC: @slel @nthiery @embray @roed314 @videlec

Component: docker

Keywords: sd109

Author: Julian Rüth

Branch/Commit: e353fd5

Reviewer: David Roe

Issue created by migration from https://trac.sagemath.org/ticket/28457
@saraedum saraedum added this to the sage-8.9 milestone Sep 5, 2019
@saraedum
Copy link
Member Author

saraedum commented Sep 5, 2019

Branch: u/saraedum/28457

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 5, 2019

Commit: 3de1e64

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 5, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

3de1e64Merge remote-tracking branch 'trac/develop' into 28457

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 6, 2019

Changed commit from 3de1e64 to e353fd5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 6, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

e353fd5fix typo

@saraedum
Copy link
Member Author

comment:4

This can be reviewed once #28041 has been merged.

@saraedum

This comment has been minimized.

Sign in to view
@slel
Copy link
Member

slel commented Dec 5, 2019

comment:6

Note #28041 was merged in 9.0.beta0, so this can now be reviewed.

@embray
Copy link
Contributor

embray commented Dec 30, 2019

comment:7

Ticket retargeted after milestone closed

@embray embray modified the milestones: sage-8.9, sage-9.1 Dec 30, 2019
@mkoeppe mkoeppe modified the milestones: sage-9.1, sage-9.2 Apr 15, 2020
@mkoeppe
Copy link
Member

mkoeppe commented May 27, 2020

Changed keywords from none to sd109

@roed314
Copy link
Contributor

roed314 commented May 28, 2020

Reviewer: David Roe

@roed314
Copy link
Contributor

roed314 commented May 28, 2020

comment:10

This looks reasonable to me.

@vbraun
Copy link
Member

vbraun commented May 29, 2020

Changed branch from u/saraedum/28457 to e353fd5

@vbraun vbraun closed this as completed in 24590ba May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: docker p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
6 participants
@roed314 @saraedum @embray @vbraun @slel @mkoeppe