Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow binary distributions to prevent rebuilding of sagelib #29158

Closed
embray opened this issue Feb 6, 2020 · 6 comments
Closed

Allow binary distributions to prevent rebuilding of sagelib #29158

embray opened this issue Feb 6, 2020 · 6 comments

Comments

@embray
Copy link
Contributor

embray commented Feb 6, 2020

This slightly odd ticket is needed for the Windows version of Sage, and might be useful in other binary distributions (e.g. Docker?) in which the src/build directory has been stripped out.

At issue here is the fact that, if you install an optional package with sage -i, after the optional package is installed it runs:

touch "$SAGE_ROOT/configure" && $MAKE all-build

If src/build has been stripped out, this means that all of sagelib gets rebuilt, even if it isn't necessary.

This solution is not perfect, however, because sagelib does have some "optional extensions", such that when installing certain optional packages it is necessary to rebuild at least part of sagelib.

So I'm open to better ideas on this, but I do need it right now for the Windows distribution.

Depends on #33131

CC: @vbraun @dimpase @jdemeyer

Component: build

Branch/Commit: u/embray/disable-force-rebuild-on-spkg-install @ c217309

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29158

@embray embray added this to the sage-9.1 milestone Feb 6, 2020
@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 17, 2020

comment:2

(dup of #29055)

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 17, 2020

comment:3

In the CI test of sage-numerical-backends-coin, I just patch this away using sed:
https://github.com/mkoeppe/sage-numerical-backends-coin/blob/master/Dockerfile-sage_binary#L39

@mkoeppe
Copy link
Contributor

mkoeppe commented May 10, 2021

comment:8

Moving to 9.4, as 9.3 has been released.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 May 10, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Aug 22, 2021
@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 8, 2022

comment:10

Work on improving the binary distribution is clearly not happening; we can close it as outdated - depending on #33131.

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 8, 2022

Dependencies: #33131

@mkoeppe mkoeppe removed this from the sage-9.5 milestone Jan 8, 2022
@dimpase
Copy link
Member

dimpase commented Jan 13, 2022

Reviewer: Dima Pasechnik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants