Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenBLAS to 0.3.9 - fixes build error of iml on fedora-32-standard #29378

Closed
mkoeppe opened this issue Mar 20, 2020 · 12 comments
Closed

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Mar 20, 2020

0.3.9 was released in Feb 2020. https://github.com/xianyi/OpenBLAS/releases

The upgrade fixes the build error of iml on fedora-32-standard, caused by our openblas installation of 0.3.6 being underlinked (details - see #29393).

The upstream tarball URL is in checksums.ini. To test the update on this branch: Use make SAGE_SPKG="sage-spkg -o" openblas; this will download the new upstream package automatically.

Related tickets:

CC: @dimpase @vbraun @jpflori @sagetrac-tmonteil @embray @timokau @jhpalmieri @zimmermann6 @mwageringel @orlitzky @kiwifb

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: 1238ca7

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29378

@mkoeppe mkoeppe added this to the sage-9.1 milestone Mar 20, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 20, 2020

Branch: u/mkoeppe/upgrade_openblas_0.3.9

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 20, 2020

Commit: 1238ca7

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 20, 2020

New commits:

1238ca7Update openblas to 0.3.9, add upstream_url

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 20, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 20, 2020

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 21, 2020

comment:4

The update by itself does not fix the errors of the type reported in #29170.

On archlinux-latest-minimal (https://github.com/mkoeppe/sage/runs/522730107):

cc -I. -I../../src/include -I../../src/include  -DHAVE_CONFIG_H   -fopenmp -fpic  -g -O2   -c integrate.c -o integrate.o
In file included from ../../src/include/R_ext/Applic.h:41,
                 from integrate.c:33:
../../src/include/R_ext/BLAS.h:103:55: error: expected declaration specifiers or '...' before ')' token
  103 |   const double *beta, double *y, const int *incy FCLEN);
      |                                                       ^

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title Update OpenBLAS to 0.3.9 Update OpenBLAS to 0.3.9 - fixes build error of iml on fedora-32-standard Mar 24, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 27, 2020

comment:6

Tests ran at https://github.com/mkoeppe/sage/actions/runs/64126739

Fixes fedora-32-standard openblas build, and no problems on other platforms with this update. Needs review

@dimpase
Copy link
Member

dimpase commented Mar 28, 2020

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Mar 28, 2020

comment:7

lgtm (we still don't know from GH Actions whether tests pass on MacOS, but I suppose it is now for the bots)

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 28, 2020

comment:8

Thanks!

I did the macOS test on my machine. The test didn't go through on GitHub because of #29418

@vbraun
Copy link
Member

vbraun commented Apr 5, 2020

Changed branch from u/mkoeppe/upgrade_openblas_0.3.9 to 1238ca7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants