-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade numpy to 1.16.6 (last release supporting py2) to fix numpy build error on local-conda-forge-macos-standard #29429
Comments
Commit: |
New commits:
|
comment:3
Thanks - off by one |
comment:4
Tests run at https://github.com/mkoeppe/sage/actions/runs/66814284, in particular to check whether this update fixes the problem reported on #29425 |
Author: Matthias Koeppe |
This comment has been minimized.
This comment has been minimized.
comment:7
Ready for review |
Reviewer: Isuru Fernando |
comment:9
Thanks! |
comment:10
This seems to cause matplotlib build to fail on Cygwin - https://github.com/mkoeppe/sage/runs/550935268 |
comment:11
Trying if a matplotlib update fixes it (#29444) |
comment:12
Test running at https://github.com/mkoeppe/sage/actions/runs/68777489 |
comment:13
Let's worry about Cygwin later. Hopefully the maintainer of the Cygwin port finds some time before the 9.1 release |
Changed branch from u/mkoeppe/upgrade_numpy_to_0_16_6__last_release_supporting_py2_ to |
numpy build fails on macOS with conda-forge (https://github.com/mkoeppe/sage/runs/542501526)
This comes from the depth of NumPy's code that tries to determine ABI by inspecting some compiled code (https://github.com/numpy/numpy/blob/master/numpy/core/setup_common.py).
An upgrade to 1.16.6 fixes the build error and works well on other platforms.
This can be tested with #29415:
Follow-up: #29425 - newer version, py3 only
CC: @isuruf @dimpase @kiwifb @embray
Component: packages: standard
Author: Matthias Koeppe
Branch/Commit:
b0c7df6
Reviewer: Isuru Fernando
Issue created by migration from https://trac.sagemath.org/ticket/29429
The text was updated successfully, but these errors were encountered: