Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade numpy to 1.16.6 (last release supporting py2) to fix numpy build error on local-conda-forge-macos-standard #29429

Closed
mkoeppe opened this issue Mar 30, 2020 · 15 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Mar 30, 2020

numpy build fails on macOS with conda-forge (https://github.com/mkoeppe/sage/runs/542501526)

Traceback (most recent call last):
  File "numpy/core/setup_common.py", line 241, in check_long_double_representation
    ltype = long_double_representation(pyod(obj))
  File "numpy/core/setup_common.py", line 401, in long_double_representation
    raise ValueError("Could not lock sequences (%s)" % saw)
ValueError: Could not lock sequences (None)

This comes from the depth of NumPy's code that tries to determine ABI by inspecting some compiled code (https://github.com/numpy/numpy/blob/master/numpy/core/setup_common.py).

An upgrade to 1.16.6 fixes the build error and works well on other platforms.

This can be tested with #29415:

  tox -e local-conda-forge-macos-standard

Follow-up: #29425 - newer version, py3 only

CC: @isuruf @dimpase @kiwifb @embray

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: b0c7df6

Reviewer: Isuru Fernando

Issue created by migration from https://trac.sagemath.org/ticket/29429

@mkoeppe mkoeppe added this to the sage-9.1 milestone Mar 30, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 30, 2020

@DaveWitteMorris
Copy link
Member

Commit: b0c7df6

@DaveWitteMorris
Copy link
Member

New commits:

b0c7df6Update numpy to 1.16.6

@DaveWitteMorris DaveWitteMorris changed the title Upgrade numpy to 0.16.6 (last release supporting py2) Upgrade numpy to 1.16.6 (last release supporting py2) Mar 30, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 30, 2020

comment:3

Thanks - off by one

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 30, 2020

comment:4

Tests run at https://github.com/mkoeppe/sage/actions/runs/66814284, in particular to check whether this update fixes the problem reported on #29425

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 31, 2020

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title Upgrade numpy to 1.16.6 (last release supporting py2) Upgrade numpy to 1.16.6 (last release supporting py2) to fix numpy build error on local-conda-forge-macos-standard Mar 31, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 31, 2020

comment:7

Ready for review

@isuruf
Copy link
Member

isuruf commented Mar 31, 2020

Reviewer: Isuru Fernando

@mkoeppe
Copy link
Member Author

mkoeppe commented Mar 31, 2020

comment:9

Thanks!

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 1, 2020

comment:10

This seems to cause matplotlib build to fail on Cygwin - https://github.com/mkoeppe/sage/runs/550935268

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 1, 2020

comment:11

Trying if a matplotlib update fixes it (#29444)

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 2, 2020

@mkoeppe
Copy link
Member Author

mkoeppe commented Apr 8, 2020

comment:13

Let's worry about Cygwin later. Hopefully the maintainer of the Cygwin port finds some time before the 9.1 release

@vbraun
Copy link
Member

vbraun commented Apr 12, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants