Follow up to #21785, use nodoctest instead of .nodoctest

[kiwifb]

In #21785 we changed the name of the file used to indicate that a folder shouldn't be doctested from nodoctest.py to .nodoctest. This stopped the python installation procedure from wanting to byte compile a file that is either empty or only text. Unfortunately, dot file are not included in the glob formula for installation. So, .nodoctest is not installed with the other files which is inconvenient for distribution and anyone who want to run doctest against the install rather than the sources.

CC: @mkoeppe

Component: doctest framework

Author: François Bissey

Branch/Commit: 3ed398c

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/29450

[kiwifb]

Commit: 3ed398c

[kiwifb]

Branch: u/fbissey/nodoctest

[kiwifb]

comment:1

I finally remembered that I needed to do this. The last month has been somewhat of a tough ride. I decided against testing against .nodoctest as well as nodoctest and nodoctest.py in control.py. Since, hopefully we'll do everything on the same release and .nodoctest is not installed, there shouldn't be any issues.

---

New commits:

3ed398c

replace .nodoctest with nodoctest

[kiwifb]

Author: François Bissey

[mkoeppe]

comment:2

Which glob formula are you referring to?

[kiwifb]

comment:3

The one for package_data in setup.py. The alternative is to try to glob dotfiles as well. I don't think that's worth it.

[kiwifb]

comment:4

That bit

      package_data = {
          'sage.libs.gap': ['sage.gaprc'],
          'sage.doctest':  ['tests/*'],
          'sage': ['ext_data/*',
                   'ext_data/kenzo/*',
                   'ext_data/singular/*',
                   'ext_data/singular/function_field/*',
                   'ext_data/images/*',
                   'ext_data/doctest/*',
                   'ext_data/doctest/invalid/*',
                   'ext_data/doctest/rich_output/*',
                   'ext_data/doctest/rich_output/example_wavefront/*',
                   'ext_data/gap/*',
                   'ext_data/gap/joyner/*',
                   'ext_data/mwrank/*',
                   'ext_data/notebook-ipython/*',
                   'ext_data/nbconvert/*',
                   'ext_data/graphs/*',
                   'ext_data/pari/*',
                   'ext_data/pari/dokchitser/*',
                   'ext_data/pari/buzzard/*',
                   'ext_data/pari/simon/*',
                   'ext_data/magma/*',
                   'ext_data/magma/latex/*',
                   'ext_data/magma/sage/*',
                   'ext_data/valgrind/*',
                   'ext_data/threejs/*']
      },

[mkoeppe]

Reviewer: Matthias Koeppe

[vbraun]

Changed branch from u/fbissey/nodoctest to 3ed398c