Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger CI workflows on GitHub Actions by pushing tags #29534

Closed
mkoeppe opened this issue Apr 20, 2020 · 19 comments
Closed

Trigger CI workflows on GitHub Actions by pushing tags #29534

mkoeppe opened this issue Apr 20, 2020 · 19 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 20, 2020

  1. If a developers wants to run the standard set of CI tests, just pushing a tag is a simpler interface than creating a pull request: git tag -f "ci" && git push --force github "ci"

  2. Also this ensures that releases always trigger a CI test.

Follow-up (wishlist): #29535 Customize CI workflows on GitHub Actions using specially structured tag names

Depends on #29403
Depends on #29341

CC: @dimpase @kliem @orlitzky

Component: porting

Keywords: ci, ContinuousIntegration

Author: Matthias Koeppe

Branch/Commit: 81fa6c3

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29534

@mkoeppe mkoeppe added this to the sage-9.1 milestone Apr 20, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 20, 2020

Changed keywords from none to ci, ContinuousIntegration

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 20, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 20, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 20, 2020

Commit: fd27d88

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 20, 2020

Last 10 new commits:

fafd554build/pkgs/libpng/distros/slackware.txt: New
eb9f1c1build/pkgs/slackware.txt: Add libxml2
f7493d9build/pkgs/libgd/distros/slackware.txt: Add dependencies
5fe6538Merge branch 't/29424/slackware__system_packages_fix' into t/29341/optional-test-9.1.rc0
84edb00.github/workflows/tox-optional.yml: Rename
7b3446f.github/workflows/tox-optional.yml: Test packages factor 'maximal'
1dda317Add cmake to packages not tested
bd8a2f9build/bin/write-dockerfile.sh [fedora]: Use 'yum install -y --download-only' for checking existence of packages
2bbd4b3Merge branch 't/29341/optional-test-9.1.rc0' into t/29534/trigger_ci_workflows_on_github_actions_by_pushing_tags
fd27d88Trigger CI with tags

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 20, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

81fa6c3Add documentation

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 20, 2020

Changed commit from fd27d88 to 81fa6c3

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 21, 2020

comment:7

Anyone interested in this?

@dimpase
Copy link
Member

dimpase commented Apr 21, 2020

comment:8

let me try this.

@dimpase
Copy link
Member

dimpase commented Apr 21, 2020

comment:9

This is a bit strange. My (shallow) understanding of tags is that they are kind of immutable branches.
Once a commit is tagged, the tag stays there.
Does pushing the same commit (as a part of another branch, say) trigger CI?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 21, 2020

comment:10

Yes, the tag doesn't move by itself, but you can move it using git tag -f.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 21, 2020

comment:11

The CI workflow is triggered only by pushes to tags, not branches.
Pushing the same tag to the same commit is a no-op and will probably not trigger the workflow.
If you want to restart a check of the same commit, just push a different tag.

@dimpase
Copy link
Member

dimpase commented Apr 22, 2020

comment:12

This looks and works OK.

@dimpase
Copy link
Member

dimpase commented Apr 22, 2020

Reviewer: Dima Pasechnik

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 22, 2020

comment:13

Thanks!

@vbraun
Copy link
Member

vbraun commented Apr 24, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants