Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage-guess-package-system: Ignore conda if no environment is activated #29560

Closed
mkoeppe opened this issue Apr 24, 2020 · 11 comments
Closed

sage-guess-package-system: Ignore conda if no environment is activated #29560

mkoeppe opened this issue Apr 24, 2020 · 11 comments
Labels
c: build: configure p: critical / 2 t: enhancement
Milestone
sage-9.1

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 24, 2020

This is so that users can get installation hints e.g. for homebrew after running conda deactivate
(as for example advised by the Anaconda detection code added by #27699)

CC: @isuruf @jhpalmieri @dimpase @slel

Component: build: configure

Author: Matthias Koeppe

Branch/Commit: 27f6bac

Reviewer: Isuru Fernando

Issue created by migration from https://trac.sagemath.org/ticket/29560
@mkoeppe mkoeppe added this to the sage-9.1 milestone Apr 24, 2020
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 24, 2020

Author: Matthias Koeppe

@jhpalmieri
Copy link
Member

comment:3

I don't see a branch.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 24, 2020

Branch: u/mkoeppe/sage_guess_package_system__ignore_conda_if_no_environment_is_activated

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 24, 2020

Commit: 27f6bac

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 24, 2020

comment:5

Ready for review

New commits:

27f6bacbuild/bin/sage-guess-package-system: Ignore conda if no environment is active

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 26, 2020

comment:8

Let's get this one in please

@isuruf
Copy link
Member

isuruf commented Apr 26, 2020

Reviewer: Isuru Fernando

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 26, 2020

comment:10

Thanks!

@vbraun
Copy link
Member

vbraun commented May 2, 2020

Changed branch from u/mkoeppe/sage_guess_package_system__ignore_conda_if_no_environment_is_activated to 27f6bac

@vbraun vbraun closed this as completed in c05af49 May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build: configure p: critical / 2 t: enhancement
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
4 participants
@vbraun @jhpalmieri @isuruf @mkoeppe