Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use yield from in poset code #29857

Closed
fchapoton opened this issue Jun 14, 2020 · 11 comments
Closed

use yield from in poset code #29857

fchapoton opened this issue Jun 14, 2020 · 11 comments
Labels
c: combinatorics p: major / 3 t: enhancement
Milestone
sage-9.2

Comments

@fchapoton
Copy link
Contributor

and other details in the Hasse diagrams

CC: @tscrim

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: cd063f3

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29857
@fchapoton fchapoton added this to the sage-9.2 milestone Jun 14, 2020
@fchapoton
Copy link
Contributor Author

New commits:

c4bf7a3some care for Hasse diagrams
50272c5some details in posets.py

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/29857

@fchapoton
Copy link
Contributor Author

Commit: 50272c5

@fchapoton
Copy link
Contributor Author

comment:2

bot is morally green, please review

@tscrim
Copy link
Collaborator

tscrim commented Jun 14, 2020

comment:3

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jun 14, 2020

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Jun 26, 2020

comment:4

Merge conflict

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 26, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

cd063f3Merge branch 'u/chapoton/29857' in 9.2.b2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 26, 2020

Changed commit from 50272c5 to cd063f3

@fchapoton
Copy link
Contributor Author

comment:7

trivial rebase, set back to positive

@vbraun
Copy link
Member

vbraun commented Jul 2, 2020

Changed branch from u/chapoton/29857 to cd063f3

@vbraun vbraun closed this as completed in 2b2aa8e Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton