Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/: Test all optional packages, add workflow for testing all experimental packages #29901

Closed
mkoeppe opened this issue Jun 19, 2020 · 49 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 19, 2020

Follow up from #29341.

Depends on #29174
Depends on #29823
Depends on #20104

CC: @jhpalmieri @novoselt @kliem @orlitzky

Component: porting

Author: Matthias Koeppe

Branch/Commit: 6afe959

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/29901

@mkoeppe mkoeppe added this to the sage-9.2 milestone Jun 19, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 19, 2020

Dependencies: #29174

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 19, 2020

Changed dependencies from #29174 to #29174, #29823

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 19, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 19, 2020

comment:5

The present version has an explicit list of the packages to the workflow scripts. This could be made less maintenance-intensive by #29902


New commits:

c182f48trac 29754: remove packages backporting Python 3 components to Python 2.
05a6937Merge commit 'c559f26caf56378c8c4a5652f577986b4f5d431c' of git://trac.sagemath.org/sage into t/29754/no-py2-backports
332778d.github/workflows/ci-cygwin*: Remove build of removed package singledispatch
b389d77Merge branch 't/29745/cleanup-spkg-rst-files' into t/29174/remove_autotools_spkg
963737ebuild/pkgs/autotools: Remove
91b5ae8Merge branches 't/29823/_github_workflows_ci_cygwin___remove_build_of_removed_packages' and 't/29174/remove_autotools_spkg' into t/29901/_github_workflows___test_all_optional_packages__add_workflow_for_testing_all_experimental_packages
f582222.github/workflows/: Test all optional packages, add workflow for testing all experimental packages

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 19, 2020

Commit: f582222

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 19, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f87c885.github/workflows/: Test all optional packages, add workflow for testing all experimental packages

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 19, 2020

Changed commit from f582222 to f87c885

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 19, 2020

comment:7

.github/workflows/: Test all optional packages, add workflow for testing all experimental packages · mkoeppe/sage@f87c885
https://github.com/mkoeppe/sage/actions/runs/141135018

.github/workflows/: Test all optional packages, add workflow for testing all experimental packages · mkoeppe/sage@f87c885
https://github.com/mkoeppe/sage/actions/runs/141135010

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 19, 2020

Changed dependencies from #29174, #29823 to #29174, #29823, #20104

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 20, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

94ec3c9Add sage --package update-latest command
cb7a291Fixup rebase
1d36a2ebuild/bin/sage-system-python: Try python first
a91ecabMerge branch 't/29890/build_bin_sage_system_python__try__python__first' into t/20104/automatic_updates_of_pip_type_packages
ba6fbb5Merge branch 't/20104/automatic_updates_of_pip_type_packages' into t/29901/_github_workflows___test_all_optional_packages__add_workflow_for_testing_all_experimental_packages
4dc7367.github/workflows: Replace explicit optional/experimental lists by using sage-package
efb14c3Suppress linebreaks

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 20, 2020

Changed commit from f87c885 to efb14c3

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 20, 2020

comment:10

https://github.com/mkoeppe/sage/runs/789828733

Error processing tar file(exit status 1): write /sage/local/share/pari/elldata/ell366: no space left on device
Error response from daemon: Error processing tar file(exit status 1): write /sage/local/share/stein_watkins/a.010.bz2: no space left on device

@jhpalmieri
Copy link
Member

comment:11

Maybe we don't need to test database_stein_watkins much: if database_stein_watkins_mini works, then since they use the same spkg-install.in, the only issue, I think, is whether the big tarball is corrupt.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 20, 2020

comment:12

Right. There was apparently a point to having that old category of "huge" packages. Wondering how that got lost. --> #29919 (Restore "huge" package type)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 20, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

2a38f51.github/workflows/tox-optional.yml: Do not test huge packages

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 20, 2020

Changed commit from efb14c3 to 2a38f51

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 20, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

1fcafe8.github/workflows/tox-optional.yml: Do not test huge packages

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 20, 2020

Changed commit from 2a38f51 to 1fcafe8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 20, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

bd703e4.github/workflows/tox-optional.yml: Do not test huge packages

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 20, 2020

Changed commit from 1fcafe8 to bd703e4

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 20, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 22, 2020

comment:17

Filtering out the known huge packages works now.

But there are many timeouts. Will need to split "optional" into 2 parts.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 14, 2020

Changed commit from bd703e4 to fc59886

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 14, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

fc59886Merge tag '9.2.beta5' into t/29901/_github_workflows___test_all_optional_packages__add_workflow_for_testing_all_experimental_packages

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 14, 2020

Changed commit from fc59886 to 1a408a8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 14, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

1a408a8.github/workflows/tox-optional.yml: Split jobs

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 15, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

50556a7Fixup syntax

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 15, 2020

Changed commit from 1a408a8 to 50556a7

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 15, 2020

comment:22

Tests for experimental packages at https://github.com/mkoeppe/sage/actions/runs/170318716

Tests for optional packages at https://github.com/mkoeppe/sage/actions/runs/170362341

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 15, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 16, 2020

comment:24

Still exceeds 2 x 6h on ubuntu-xenial, need to split it up more

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 16, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

6e3051dSplit up into more jobs

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 16, 2020

Changed commit from 50556a7 to 6e3051d

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 16, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 16, 2020

comment:27

Should remove the testing of sage_numerical_backends_cplex, sage_numerical_backends_gurobi, which require the commercial packages to be installed first

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 16, 2020

Changed commit from 6e3051d to 6afe959

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 16, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

6c82896Even more splitting
6afe959Do not try to test packages that need cplex, gurobi

@kliem
Copy link
Contributor

kliem commented Jul 17, 2020

comment:29

Why are there green checkmarks, if things haven't worked out?

https://github.com/mkoeppe/sage/runs/876312084?check_suite_focus=true

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 17, 2020

comment:30

Targets listed in TARGETS_OPTIONAL ignore errors.

@kliem
Copy link
Contributor

kliem commented Jul 17, 2020

comment:31

Why is that? There is probably a good reason, but I'm curious. How do I efficiently use it then.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 17, 2020

comment:32

Unfortunately a test run can only get a red or a green status on GH Actions.
TARGETS_OPTIONAL is designed for additional tests of things that are likely to fail - such as ptest in tox.yml, which always has 1 or 2 failures that we don't want to be signaled by a red status.

There's only a rather shallow reason why currently use TARGETS_OPTIONAL for testing the optional and experimental packages. At the moment the majority of the optional and experimental packages fail, so all of these test runs will fail. Thus there is no information either way. But the green checkmarks look more friendly.

We can change this when we have made some progress in #29900 (Meta-ticket: Fix optional and experimental packages for Sage 9.2).

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 17, 2020

comment:33

Replying to @kliem:

How do I efficiently use it then.

Look at the "This run" tab of the whole workflow and search for package names that you're interested in.

@kliem
Copy link
Contributor

kliem commented Jul 17, 2020

comment:34

Thanks. Yes, sounds reasonable.

From my point of view, optional should mean almost as safe as sage itself and experimental is for all stuff that might or might not work (I guess there are runtime failures as well that make stuff experimental). So adding a doctesting framework for this seems great.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 17, 2020

comment:35

Replying to @kliem:

From my point of view, optional should mean almost as safe as sage itself and experimental is for all stuff that might or might not work (I guess there are runtime failures as well that make stuff experimental).

Yes, I agree with this interpretation.

@kliem
Copy link
Contributor

kliem commented Jul 17, 2020

Reviewer: Jonathan Kliem

@kliem
Copy link
Contributor

kliem commented Jul 17, 2020

comment:36

I think this is a good improvement as it is.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 17, 2020

comment:37

Thanks!

@vbraun
Copy link
Member

vbraun commented Jul 25, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants