-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github/workflows/: Test all optional packages, add workflow for testing all experimental packages #29901
Comments
Dependencies: #29174 |
This comment has been minimized.
This comment has been minimized.
comment:5
The present version has an explicit list of the packages to the workflow scripts. This could be made less maintenance-intensive by #29902 New commits:
|
Commit: |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:7
.github/workflows/: Test all optional packages, add workflow for testing all experimental packages · mkoeppe/sage@f87c885 .github/workflows/: Test all optional packages, add workflow for testing all experimental packages · mkoeppe/sage@f87c885 |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:10
https://github.com/mkoeppe/sage/runs/789828733
|
comment:11
Maybe we don't need to test |
comment:12
Right. There was apparently a point to having that old category of "huge" packages. Wondering how that got lost. --> #29919 (Restore "huge" package type) |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:16
New test at https://github.com/mkoeppe/sage/actions/runs/141954265 |
comment:17
Filtering out the known huge packages works now. But there are many timeouts. Will need to split "optional" into 2 parts. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:22
Tests for experimental packages at https://github.com/mkoeppe/sage/actions/runs/170318716 Tests for optional packages at https://github.com/mkoeppe/sage/actions/runs/170362341 |
Author: Matthias Koeppe |
comment:24
Still exceeds 2 x 6h on |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:27
Should remove the testing of |
comment:29
Why are there green checkmarks, if things haven't worked out? https://github.com/mkoeppe/sage/runs/876312084?check_suite_focus=true |
comment:30
Targets listed in |
comment:31
Why is that? There is probably a good reason, but I'm curious. How do I efficiently use it then. |
comment:32
Unfortunately a test run can only get a red or a green status on GH Actions. There's only a rather shallow reason why currently use We can change this when we have made some progress in #29900 (Meta-ticket: Fix optional and experimental packages for Sage 9.2). |
comment:33
Replying to @kliem:
Look at the "This run" tab of the whole workflow and search for package names that you're interested in. |
comment:34
Thanks. Yes, sounds reasonable. From my point of view, optional should mean almost as safe as sage itself and experimental is for all stuff that might or might not work (I guess there are runtime failures as well that make stuff experimental). So adding a doctesting framework for this seems great. |
comment:35
Replying to @kliem:
Yes, I agree with this interpretation. |
Reviewer: Jonathan Kliem |
comment:36
I think this is a good improvement as it is. |
comment:37
Thanks! |
Follow up from #29341.
Depends on #29174
Depends on #29823
Depends on #20104
CC: @jhpalmieri @novoselt @kliem @orlitzky
Component: porting
Author: Matthias Koeppe
Branch/Commit:
6afe959
Reviewer: Jonathan Kliem
Issue created by migration from https://trac.sagemath.org/ticket/29901
The text was updated successfully, but these errors were encountered: