Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle SAGE_CHECK_PACKAGES in build/make/Makefile.in, not sage-spkg #30118

Closed
mkoeppe opened this issue Jul 12, 2020 · 15 comments
Closed

Handle SAGE_CHECK_PACKAGES in build/make/Makefile.in, not sage-spkg #30118

mkoeppe opened this issue Jul 12, 2020 · 15 comments
Labels
c: build p: critical / 2 t: enhancement
Milestone
sage-9.2

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 12, 2020

#29766, #29441, and #29497 introduce build dependencies for packages that are only active when SAGE_CHECK is not no.

But whether a package needs its check-dependencies depends on both SAGE_CHECK_PACKAGES and SAGE_CHECK.

In this ticket, we move the handling of SAGE_CHECK_PACKAGES from sage-spkg to the Makefile.

This allows packages to conditionalize dependencies based on the new makefile variables SAGE_CHECK_symengine_py (for #29497) etc.

CC: @jhpalmieri @orlitzky @kliem @kiwifb

Component: build

Author: Matthias Koeppe

Branch/Commit: 5d13238

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/30118
@mkoeppe mkoeppe added this to the sage-9.2 milestone Jul 12, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 12, 2020

Branch: u/mkoeppe/handle_sage_check_packages_in_build_make_makefile_in__not_sage_spkg

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 12, 2020

New commits:

25393b0Handle SAGE_CHECK_PACKAGES in build/make/Makefile.in, not sage-spkg

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 12, 2020

Commit: 25393b0

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 12, 2020

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 12, 2020

comment:5

Marking it as critical as it is needed for CI testing of blocker package upgrade ticket #29766

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 16, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

5d13238Merge tag '9.2.beta5' into t/30118/handle_sage_check_packages_in_build_make_makefile_in__not_sage_spkg

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 16, 2020

Changed commit from 25393b0 to 5d13238

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 16, 2020

comment:8

Merged current beta, needs review

@dimpase
Copy link
Member

dimpase commented Jul 17, 2020

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Jul 17, 2020

comment:9

looks good as refactoring.
We'll see how the conditional deps work on follow-up tickets, I suppose

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 17, 2020

comment:10

Thanks!

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 17, 2020

comment:11

Yes, I'm already using this in various test runs.

@vbraun
Copy link
Member

vbraun commented Jul 25, 2020

Changed branch from u/mkoeppe/handle_sage_check_packages_in_build_make_makefile_in__not_sage_spkg to 5d13238

@vbraun vbraun closed this as completed in 14e97a8 Jul 25, 2020
@videlec videlec mentioned this issue Sep 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: critical / 2 t: enhancement
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
3 participants
@vbraun @dimpase @mkoeppe