Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox.ini / tox.yml: Move code for tagging/pushing docker images into tox.ini #30144

Closed
mkoeppe opened this issue Jul 14, 2020 · 16 comments
Closed

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jul 14, 2020

Currently, there are reliability issues on GitHub Actions, builds time out or die for no apparent reason, and then no docker images are pushed.

We integrate this code into tox.ini so that the pushing happens after each of the steps defined by DOCKER_TARGETS.

Then one can pull an intermediate image and continue some tests locally.

CC: @kliem @dimpase

Component: porting

Author: Matthias Koeppe

Branch/Commit: 231b812

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/30144

@mkoeppe mkoeppe added this to the sage-9.2 milestone Jul 14, 2020
@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 12, 2020

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 12, 2020

Reviewer: github.com/mkoeppe/sage/actions/runs/206174675, ...

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 12, 2020

New commits:

cf25b83Move code for tagging/pushing docker images into tox.ini
51c6cdefixup
231b812.github-workflows/tox-*.yml: Update similarly

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 12, 2020

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 12, 2020

Commit: 231b812

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 13, 2020

Changed reviewer from github.com/mkoeppe/sage/actions/runs/206174675, ... to https://github.com/mkoeppe/sage/actions/runs/206465268

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 14, 2020

comment:4

This seems to work well (see for example https://github.com/mkoeppe/sage/runs/978681914); needs review

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 14, 2020

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 18, 2020

comment:6

Let's get this in please.

@kliem
Copy link
Contributor

kliem commented Aug 18, 2020

comment:7

Is this to worry about?

 WARNING! Your password will be stored unencrypted in /home/runner/.docker/config.json.
Configure a credential helper to remove this warning. See
https://docs.docker.com/engine/reference/commandline/login/#credentials-store

Otherwise looks fine.

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 18, 2020

comment:8

This warning is not new, it used to appear in the "push docker images step".

The "password" here is a token specifically created for the GitHub packages repository. I don't have a major concern about storing it in cleartext.

See also docker/build-push-action#53, where the same issue is open for Docker's official actions.

@kliem
Copy link
Contributor

kliem commented Aug 18, 2020

comment:9

I figured it was something like this. Just wanted to make sure.

@kliem
Copy link
Contributor

kliem commented Aug 18, 2020

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/206465268, ... to Jonathan Kliem

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 18, 2020

comment:11

Thanks!

@vbraun
Copy link
Member

vbraun commented Aug 20, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants