Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrivialFamily: Accept start index #30259

Closed
mkoeppe opened this issue Jul 31, 2020 · 11 comments
Closed

TrivialFamily: Accept start index #30259

mkoeppe opened this issue Jul 31, 2020 · 11 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 31, 2020

sage.tensor.modules has a feature start_index. By setting start_index=1 (default: 0), a basis is indexed starting at 1.

We add this feature to TrivialFamily (and the factory Family).

This is another small step to improve compatibility with CombinatorialFreeModule.

Depends on #30300

CC: @egourgoulhon @tscrim @mjungmath

Component: combinatorics

Branch/Commit: u/mkoeppe/trivialfamily__accept_start_index @ f4f1a60

Issue created by migration from https://trac.sagemath.org/ticket/30259

@mkoeppe mkoeppe added this to the sage-9.2 milestone Jul 31, 2020
@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Aug 13, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 13, 2021

comment:2

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 1, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 23, 2022

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 23, 2022

comment:7

easier to just do what is needed in #30300


New commits:

f4f1a60src/sage/sets/family.py: WIP start_index

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 23, 2022

Commit: f4f1a60

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 23, 2022

Dependencies: #30300

@mkoeppe mkoeppe removed this from the sage-9.7 milestone Aug 23, 2022
@tscrim
Copy link
Collaborator

tscrim commented Aug 24, 2022

comment:8

I am confused. Is this a wontfix or a regular review?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 24, 2022

comment:9

wontfix

@tscrim
Copy link
Collaborator

tscrim commented Aug 24, 2022

comment:10

But #30300 is unrelated to this ticket and the feature request.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 24, 2022

comment:11

I thought I would implement #30300 by going through this ticket here.
But it turned out not to be useful.

@tscrim
Copy link
Collaborator

tscrim commented Aug 24, 2022

comment:12

I see. Do you think this might still be a useful feature for some to have?

@jhpalmieri
Copy link
Member

Closing as "won't fix" since that is the branch author's preference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants