Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Immutability of Bundle Connections #30284

Closed
mjungmath opened this issue Aug 4, 2020 · 34 comments
Closed

Immutability of Bundle Connections #30284

mjungmath opened this issue Aug 4, 2020 · 34 comments
Labels
c: manifolds p: major / 3 t: enhancement
Milestone
sage-9.3

Comments

@mjungmath
Copy link

Immutability of bundle connections. Furthermore, a copy method is added.

See #30261.

Depends on #31181
Depends on #31182
Depends on #31215
Depends on #31273

CC: @egourgoulhon @tscrim @mkoeppe

Component: manifolds

Keywords: immutability

Author: Michael Jung

Branch/Commit: 70a1d9a

Reviewer: Eric Gourgoulhon

Issue created by migration from https://trac.sagemath.org/ticket/30284
@mjungmath mjungmath added this to the sage-9.2 milestone Aug 4, 2020
@mjungmath
Copy link
Author

Branch: u/gh-mjungmath/immutability_of_bundle_connections

@mjungmath
Copy link
Author

Changed keywords from none to immutability

@mjungmath
Copy link
Author

Commit: ca3a9d7

@mjungmath

This comment has been minimized.

Sign in to view
@mjungmath
Copy link
Author

Dependencies: #30208, #30209

@mjungmath
Copy link
Author

Author: Michael Jung

@mjungmath
Copy link
Author

Last 10 new commits:

d58d291Trac #30266: hash function condition + treatment of restrictions
061b89fTrac #30266: minor doctest improvement
5c7fd6eTrac #30266: immutability of restrictions + hash function improved
7ba0865Trac #30266: merge
0ec99d4Trac #30266: check by name
87fb411Trac #30266: ValueError replaced by AssertionError
43ec497Trac #30239: referenced before assignment error fixed
135ffd5Trac #30209: Merge branch 't/30239/tensorfield___call___alters_zero' into bundle_connection_change_of_frame
4d9209eTrac #30284: Merge branch 'bundle_connection_change_of_frame' into t/30284/immutability_of_bundle_connections
ca3a9d7Trac #30284: make bundle connections immutable + improved documentation

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 4, 2020

Changed commit from ca3a9d7 to db3d290

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 4, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

933c14aTrac #30209: Merge branch 'develop' into bundle_connection_change_of_frame
db3d290Trac #30284: Merge branch 'bundle_connection_change_of_frame' into t/30284/immutability_of_bundle_connections

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 6, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0685f7bTrac #30239: doctest fixed
e13b168Trac #30239: check by name for general tensor field action
4ff3431Trac #30239: try-finally instead of try-except
c1c74deRevert "Trac #30239: try-finally instead of try-except"
5cee80cTrac #30209: Merge branch 'bundle_connection_extension' into bundle_connection_action
21f2bd5Trac #30209: bundle connections acting on sections + vector fields
6cb7ff8Trac #30284: Merge branch 't/30209/bundle_connection_change_of_frame' into immutability_bundle_connection
cccf487Trac #30284: Merge branch 't/30274/immutability_of_tensor_fields' into immutability_bundle_connection
25650abTrac #30284: immutability bundle connection + copy method

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 6, 2020

Changed commit from db3d290 to 25650ab

@mjungmath

This comment has been minimized.

Sign in to view
@mjungmath
Copy link
Author

Changed dependencies from #30208, #30209 to #30208, #30209, #30274

@mjungmath
Copy link
Author

comment:6

Branches diverged due to #30209. I will fix this as soon as #30209 has a positive review.

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Sep 5, 2020
@mjungmath
Copy link
Author

Changed dependencies from #30208, #30209, #30274 to #31181, #31182

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 7, 2021

Changed commit from 25650ab to 8c2c481

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 7, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

1201f11Trac #30284: use Mutability mixin + copy method
8c2c481Trac #30284: `__hash__` requires immutability

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 7, 2021

Changed commit from 8c2c481 to deda20d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 7, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

deda20dTrac #30284: hash function improved

@mjungmath

This comment has been minimized.

Sign in to view
@mjungmath

This comment has been minimized.

Sign in to view
@mjungmath
Copy link
Author

Changed dependencies from #31181, #31182 to #31181, #31182, #31215

@mjungmath
Copy link
Author

Changed dependencies from #31181, #31182, #31215 to #31181, #31182, #31215, #31273

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 21, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

e5228d3Trac #31196: cpdef require methods + example added
d957f73Trac #31196: unnecessary line in docstring removed
d6d6ba4Trac #31182: `__getstate__` and __setstate__
6cbd1fdTrac #31182: doctests added for `__setstate__` and __getstate__
9b8d52bMerge branch 't/31182/mutability_class_and_pickling' into immutability_of_bundle_connections
2ce59fbTrac #31215: assignment behavior better documented
dbc7946Merge branch 't/31215/bundle_connection_document_assignment_behavior' into immutability_of_bundle_connections
5381682Trac #31273: remove deprecated "form" input
999bd3eMerge branch 't/31273/remove_deprecated__form__input_for_bundle_connections' into immutability_of_bundle_connections
d5da652Trac #30284: mixin mutability module + improved hash

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 21, 2021

Changed commit from deda20d to d5da652

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 21, 2021

Changed commit from d5da652 to 70a1d9a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 21, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

70a1d9aTrac #30284: make connections immutable before usage of characteristic classes

@mjungmath
Copy link
Author

comment:17

Green patchbot.

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 15, 2021

comment:18

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Mar 15, 2021
@mjungmath
Copy link
Author

comment:19

Travis, Eric, is that implementation fine or should I change something here? Patchbot is still green.

@egourgoulhon
Copy link
Member

Reviewer: Eric Gourgoulhon

@egourgoulhon
Copy link
Member

comment:20

Replying to @mjungmath:

Travis, Eric, is that implementation fine or should I change something here? Patchbot is still green.

The implementation seems fine. Sorry the delay in the review.

@egourgoulhon egourgoulhon modified the milestones: sage-9.4, sage-9.3 Mar 20, 2021
@mjungmath
Copy link
Author

comment:21

Thanks Eric! :)

@vbraun
Copy link
Member

vbraun commented Mar 22, 2021

Changed branch from u/gh-mjungmath/immutability_of_bundle_connections to 70a1d9a

@vbraun vbraun closed this as completed in badd79c Mar 22, 2021
@mjungmath mjungmath mentioned this issue Jul 25, 2021
Closed
@egourgoulhon egourgoulhon mentioned this issue Jan 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: manifolds p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
4 participants
@vbraun @egourgoulhon @mkoeppe @mjungmath