Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up pypolybori #30618

Closed
fchapoton opened this issue Sep 20, 2020 · 22 comments
Closed

clean up pypolybori #30618

fchapoton opened this issue Sep 20, 2020 · 22 comments

Comments

@fchapoton
Copy link
Contributor

that was recently included in sage without much care about refreshing its code..

reference : #30332

CC: @kiwifb @orlitzky @tscrim @mkoeppe

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 51592e0

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/30618

@fchapoton fchapoton added this to the sage-9.3 milestone Sep 20, 2020
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/30618

@fchapoton
Copy link
Contributor Author

Commit: dc0b9ad

@fchapoton
Copy link
Contributor Author

New commits:

dc0b9adcleaning up pypolybori (start of the task)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 20, 2020

Changed commit from dc0b9ad to e2ad5e0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 20, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

e2ad5e0fix back imports for the moment

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 20, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

d752eabremove offending import all

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 20, 2020

Changed commit from e2ad5e0 to d752eab

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 20, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

df037c2more import cleanup in pypolybori

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 20, 2020

Changed commit from d752eab to df037c2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 20, 2020

Changed commit from df037c2 to 6b19700

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 20, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

6b19700more direct import in pbori

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 20, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

4447885various details in pbori
68cffc2better imports (py3) in pbori

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 20, 2020

Changed commit from 6b19700 to 68cffc2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 20, 2020

Changed commit from 68cffc2 to 7b12b2c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 20, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

7b12b2ccode details in pbori

@fchapoton

This comment has been minimized.

@tscrim
Copy link
Collaborator

tscrim commented Sep 20, 2020

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Sep 20, 2020

comment:9

LGTM.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 1, 2020

Changed commit from 7b12b2c to 51592e0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 1, 2020

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

51592e0Merge branch 'u/chapoton/30618' in 9.2.b14

@fchapoton
Copy link
Contributor Author

comment:11

trivial rebase, setting back to positive

@vbraun
Copy link
Member

vbraun commented Oct 5, 2020

Changed branch from u/chapoton/30618 to 51592e0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants