Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/bin/sage-env: Update MACOSX_DEPLOYMENT_TARGET in builds with python3 from SPKG #30711

Closed
mkoeppe opened this issue Oct 3, 2020 · 7 comments
Closed

src/bin/sage-env: Update MACOSX_DEPLOYMENT_TARGET in builds with python3 from SPKG #30711

mkoeppe opened this issue Oct 3, 2020 · 7 comments
Labels
c: porting r: invalid t: bug

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 3, 2020

(from #30494)

Previous tickets: #27824, #18272, #16312

Depends on #30724

CC: @jhpalmieri

Component: porting

Issue created by migration from https://trac.sagemath.org/ticket/30711
@mkoeppe mkoeppe added this to the sage-9.2 milestone Oct 3, 2020
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 5, 2020

Dependencies: #30724

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 5, 2020

comment:2

Depends on #30724 - which touches the same code

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Oct 24, 2020
@jhpalmieri
Copy link
Member

comment:4

There is a branch at #18272 that may handle this issue.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 7, 2021

comment:5

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Apr 7, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 7, 2021

comment:6

The code that was setting MACOSX_DEPLOYMENT_TARGET was removed in #18272, so we can close this ticket.

@mkoeppe mkoeppe removed this from the sage-9.4 milestone Jun 7, 2021
@jhpalmieri
Copy link
Member

comment:7

I agree.

@mkoeppe mkoeppe closed this as completed Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: porting r: invalid t: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhpalmieri @mkoeppe