Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ore_algebra optional package #31239

Closed
sagetrac-tmonteil mannequin opened this issue Jan 14, 2021 · 11 comments
Closed

Add ore_algebra optional package #31239

sagetrac-tmonteil mannequin opened this issue Jan 14, 2021 · 11 comments

Comments

@sagetrac-tmonteil
Copy link
Mannequin

sagetrac-tmonteil mannequin commented Jan 14, 2021

This package was removed because there was no upstream release (see #26332), but the development is still ongoing https://github.com/mkauers/ore_algebra and the developers follow the Sage development.

We should be able to use a "pip" package source type, with a requirements.txt pointing to a commit (or a tag) of the version that works with the given Sage release.

See the task #31164.

CC: @mkauers @mezzarobba @videlec

Component: packages: optional

Author: Thierry Monteil

Branch/Commit: 9233311

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/31239

@sagetrac-tmonteil sagetrac-tmonteil mannequin added this to the sage-9.3 milestone Jan 14, 2021
@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Jan 17, 2021

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Jan 17, 2021

New commits:

4f16b49#31239 : ore_algebra optional package.

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Jan 17, 2021

Commit: 4f16b49

@sagetrac-tmonteil

This comment has been minimized.

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Jan 17, 2021

Author: Thierry Monteil

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 17, 2021

comment:3

As setup.py is using sage.env, this will need a dependencies file, see discussion in #31224

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 17, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

9233311#31239 : depenencies (comment:3).

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 17, 2021

Changed commit from 4f16b49 to 9233311

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Jan 17, 2021

comment:5

Done.

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 17, 2021

Reviewer: Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented Jan 31, 2021

Changed branch from u/tmonteil/add_ore_algebra_optional_package to 9233311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants