Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make self-diffeomorphisms default #31323

Closed
tobiasdiez opened this issue Feb 2, 2021 · 5 comments
Closed

Make self-diffeomorphisms default #31323

tobiasdiez opened this issue Feb 2, 2021 · 5 comments

Comments

@tobiasdiez
Copy link
Contributor

Currently, if you construct a diffeomorphism from a manifold to itself, you have to specify the manifold as the codmain. With the changes in this ticket, this is no longer necessary and we assume that the user want's to specify a self-diffeomorphism if no codomain is given.

CC: @tscrim @nthiery @mjungmath @egourgoulhon @mkoeppe

Component: manifolds

Author: Tobias Diez

Branch/Commit: 54d4cd3

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/31323

@tobiasdiez tobiasdiez added this to the sage-9.3 milestone Feb 2, 2021
@tscrim
Copy link
Collaborator

tscrim commented Feb 3, 2021

comment:2

Seems very reasonable and is in line with Hom. LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Feb 3, 2021

Reviewer: Travis Scrimshaw

@egourgoulhon
Copy link
Member

comment:3

Thanks for this improvement!

Side comment: when you open a ticket like this, could you please add it to the metaticket #30525 ? This helps keeping track on what's going on, especially to prepare the release tours and the changelogs. I've just done it for this ticket, as well as for #31322.
Moreover the Cc field of Track is not 100% reliable (recently I've not been notified about some ticket while my username was added in Cc; such an issue has been already reported by others in the past).

@tobiasdiez
Copy link
Contributor Author

comment:4

Thanks!

Next time I'll also add them to the metaticket.

@vbraun
Copy link
Member

vbraun commented Mar 9, 2021

Changed branch from public/manifolds/diffeo_self_default to 54d4cd3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants