Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galois groups for finite fields #31469

Closed
roed314 opened this issue Mar 8, 2021 · 19 comments
Closed

Galois groups for finite fields #31469

roed314 opened this issue Mar 8, 2021 · 19 comments

Comments

@roed314
Copy link
Contributor

roed314 commented Mar 8, 2021

We should add Galois groups of finite fields, in parallel to the Galois groups of number fields. They will be used in #25902 for algebraic tori.

Depends on #28782
Depends on #23801

CC: @saraedum @xcaruso

Component: finite rings

Author: David Roe

Branch/Commit: f09750d

Reviewer: Xavier Caruso

Issue created by migration from https://trac.sagemath.org/ticket/31469

@roed314 roed314 added this to the sage-9.3 milestone Mar 8, 2021
@roed314
Copy link
Contributor Author

roed314 commented Mar 10, 2021

Branch: u/roed/gf_galois

@roed314
Copy link
Contributor Author

roed314 commented Mar 10, 2021

Last 10 new commits:

82ff4d3Fix relative fields, implement Travis' suggestion on key for _pol_galgp
bdc5d06Fix doctest
15a2bf6Working on Galois groups over finite fields
ea5b428Working on Galois groups of finite fields
4b67449Working on Galois groups of finite fields
02e858bWorking on subfields of finite fields
cf896f3Fix test failure, documentation in algebraic closure
424a96eMerge branch 'u/roed/subfields' of git://trac.sagemath.org/sage into t/31469/gf_galois
c80ede2Choose default variable name in subfield, as in subfields
57dc39bMerge branch 't/23801/subfields' into t/31469/gf_galois

@roed314
Copy link
Contributor Author

roed314 commented Mar 10, 2021

Dependencies: #28782, #23801

@roed314
Copy link
Contributor Author

roed314 commented Mar 10, 2021

Author: David Roe

@roed314
Copy link
Contributor Author

roed314 commented Mar 10, 2021

Commit: 57dc39b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 11, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

7937212Refactor galois groups for abelian groups

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 11, 2021

Changed commit from 57dc39b to 7937212

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 11, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

b3fcfc5Fix pyflakes, coverage

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 11, 2021

Changed commit from 7937212 to b3fcfc5

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 24, 2021

comment:6

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Mar 24, 2021
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 29, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

1c99275Merge branch 'develop' into t/31469/gf_galois
24cf4ddReviewer suggestions

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 29, 2021

Changed commit from b3fcfc5 to 24cf4dd

@xcaruso
Copy link
Contributor

xcaruso commented Apr 29, 2021

comment:8

OK, perfect. LGTM.

@xcaruso
Copy link
Contributor

xcaruso commented Apr 29, 2021

Reviewer: Xavier Caruso

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 30, 2021

Changed commit from 24cf4dd to f09750d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 30, 2021

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

f09750dFix a bug with relative number field Galois groups

@roed314
Copy link
Contributor Author

roed314 commented Apr 30, 2021

comment:10

The definition of _field_degree as the relative degree was wrong, since for the moment we're converting Galois groups of relative extensions to the Galois group of the corresponding absolute field (for backward compatibility and because we can't compute Galois groups of relative extensions in general).

@xcaruso
Copy link
Contributor

xcaruso commented Apr 30, 2021

comment:11

Good point.

@vbraun
Copy link
Member

vbraun commented May 27, 2021

Changed branch from u/roed/gf_galois to f09750d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants