Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move build/sage_bootstrap to pkgs/sage-bootstrap/sage_bootstrap #31662

Open
mkoeppe opened this issue Apr 12, 2021 · 19 comments · May be fixed by #38587
Open

Move build/sage_bootstrap to pkgs/sage-bootstrap/sage_bootstrap #31662

mkoeppe opened this issue Apr 12, 2021 · 19 comments · May be fixed by #38587

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 12, 2021

We transform build/sage_bootstrap to a new pip-installable distribution sage-bootstrap (with source dir SAGE_ROOT/pkgs/sage-bootstrap).

Other bits from SAGE_ROOT and build/ become package data of this distribution, for now via symlinks.

In:

SAGE_ROOT
- pkgs
  - sage-bootstrap
    - bin
      - sage-apply-patches
      - sage-bootstrap-python
      - sage-dist-helpers
      - sage-package
      - sage-pip-*install
      - sage-print-system-package-command
      - sage-spkg*
      - sage-uncompress-spkg
      - sage-venv
    - pyproject.toml
    - sage_bootstrap/
      - pkgs/        -> SAGE_ROOT/build/pkgs
      - m4/          -> SAGE_ROOT/m4
- build/pkgs
  - sage_bootstrap
     - bootstrap

Out:

  • parts of the specific config / build system of the Sage distribution: configure.ac, build/make, build/bin/sage-site, build/bin/sage-logger, build/bin/sage-starts, build/bin/sage-sdist, build/bin/sage-site
  • monorepo driver: SAGE_ROOT/bootstrap, tox.ini, .ci/write-dockerfile.sh,

We put an sdist of the distribution 'sage-bootstrap' on PyPI, to give users easy access to commands such as sage-print-system-package-command. This can be useful for other projects that want to generate system package advice.

Depends on #31577

CC: @dimpase @jhpalmieri

Component: build

Work Issues: Set PYTHONPATH wherever PATH is set to include build/bin

Author: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/31662

@mkoeppe mkoeppe added this to the sage-9.4 milestone Apr 12, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Mar 5, 2022
@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title Rename SAGE_ROOT/build to SAGE_ROOT/sage_bootstrap Rename SAGE_ROOT/build to SAGE_ROOT/pkgs/sage-bootstrap Aug 11, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 11, 2022
@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 11, 2022

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

25eadf1pkgs/sage-bootstrap/setup.cfg: New

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2022

Commit: 25eadf1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 12, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

05b202bMake build/pkgs a symlink to sage_bootstrap package_data
2a5f45epkgs/sage-bootstrap/sage_bootstrap/sage_root_source: Move it all here, symlink to SAGE_ROOT

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 12, 2022

Changed commit from 25eadf1 to 2a5f45e

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title Rename SAGE_ROOT/build to SAGE_ROOT/pkgs/sage-bootstrap Move build/sage_bootstrap to pkgs/sage-bootstrap/sage_bootstrap Aug 12, 2022
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 12, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

830d804pkgs/sage-bootstrap/sage_bootstrap: Move here from build/sage_bootstrap

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 12, 2022

Changed commit from 2a5f45e to 830d804

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 12, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

632678cpkgs/sage-bootstrap: Use setuptools, add metadata

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 12, 2022

Changed commit from 830d804 to 632678c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 12, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

07955b0build/pkgs/sage_bootstrap: New

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 12, 2022

Changed commit from 632678c to 07955b0

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 12, 2022

Work Issues: Set PYTHONPATH wherever PATH is set to include build/bin

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 12, 2022

Author: Matthias Koeppe

@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Dec 31, 2022
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Mar 16, 2023
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 29, 2024

Removed branch from issue description. Replaced by PR #38587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant