Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage_setup.setenv: Only set ...PATH variables and LDFLAGS if SAGE_LOCAL differs from SAGE_VENV #32057

Closed
mkoeppe opened this issue Jun 24, 2021 · 13 comments
Closed

sage_setup.setenv: Only set ...PATH variables and LDFLAGS if SAGE_LOCAL differs from SAGE_VENV #32057

mkoeppe opened this issue Jun 24, 2021 · 13 comments
Labels
c: build p: major / 3 t: enhancement
Milestone
sage-9.4

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 24, 2021

Here's a different attempt to solve the issue at #31338 comment:13

This will need to be tested with #29039, #31396, for which this mechanism was created.

CC: @kiwifb @antonio-rojas

Component: build

Author: Matthias Koeppe

Branch/Commit: 0867811

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/32057
@mkoeppe mkoeppe added this to the sage-9.4 milestone Jun 24, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 24, 2021

Branch: u/mkoeppe/sage_setup_setenv__only_set____path_variables_and_ldflags_if_sage_local_differs_from_sage_venv

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 24, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 24, 2021

Commit: 0867811

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 24, 2021

New commits:

0867811src/sage_setup/setenv.py: Only set ...PATH variables and LDFLAGS if SAGE_LOCAL differs from SAGE_VENV

@kiwifb
Copy link
Member

kiwifb commented Jun 24, 2021

comment:3

Does what it says on the tin for sage-on-gentoo. No more log pollution.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 24, 2021

comment:4

Thanks for testing!

@kiwifb
Copy link
Member

kiwifb commented Jun 24, 2021

comment:5

It is a positive for me but we have to check it ticks all the other boxes you mention in the description.

@dimpase
Copy link
Member

dimpase commented Jun 27, 2021

comment:6

ready for review?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 27, 2021

comment:8

Sure, let's get this in.

@kiwifb
Copy link
Member

kiwifb commented Jun 27, 2021

Reviewer: François Bissey

@kiwifb
Copy link
Member

kiwifb commented Jun 27, 2021

comment:9

Well I am happy to it a glowing review.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 27, 2021

comment:10

Thanks!

@vbraun
Copy link
Member

vbraun commented Jul 6, 2021

Changed branch from u/mkoeppe/sage_setup_setenv__only_set____path_variables_and_ldflags_if_sage_local_differs_from_sage_venv to 0867811

@vbraun vbraun closed this as completed in d439c06 Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.4
Development

No branches or pull requests
4 participants
@kiwifb @vbraun @dimpase @mkoeppe