Chart._parse_coordinates

[mkoeppe]

Replacing _init_coordinates.

Split out from #31894, for #32102.

Depends on #32009

CC: @egourgoulhon @vbraun

Component: manifolds

Author: Matthias Koeppe

Branch/Commit: u/mkoeppe/chart__parse_coordinates @ 3d1c44d

Reviewer: Eric Gourgoulhon

Issue created by migration from https://trac.sagemath.org/ticket/32116

[mkoeppe]

Dependencies: #32009

[mkoeppe]

Branch: u/mkoeppe/chart__parse_coordinates

[mkoeppe]

New commits:

8ba174c	Eliminate direct use of Chart._domain
21297f3	Merge #32009
deace83	Chart: Replace _init_coordinates by _parse_coordinates
4db4995	Chart: Fix up `__classcall__` and _parse_coordinates by avoiding unhashable things

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

Commit: 4db4995

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

fc59c9d

Chart.__classcall__: Add doctest

[sagetrac-git]

Changed commit from 4db4995 to fc59c9d

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

f43b358	Chart._init_coordinates: Fix up use of domain
4e316e9	Fix bug in Chart.__init__ regarding the determination of top charts (Trac #32112)
907c9bc	Merge #32112
1742fdc	Merge #32009

[sagetrac-git]

Changed commit from fc59c9d to 1742fdc

[egourgoulhon]

comment:6

In line 413 of chart.py, the doctest

sage: Chart._parse_coordinates(M, ['z1:\zeta_1', r'z2:\zeta_2'])

fails due to a missing raw string marker.

[egourgoulhon]

comment:7

Apart from comment:6, this looks nice!

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

9ac1834

src/sage/manifolds/chart.py: Add raw string marker

[sagetrac-git]

Changed commit from 1742fdc to 9ac1834

[egourgoulhon]

comment:9

Thanks!

[egourgoulhon]

Reviewer: Eric Gourgoulhon

[mkoeppe]

comment:10

Thank you!

[sagetrac-git]

Changed commit from 9ac1834 to 3d1c44d

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. Last 10 new commits:

69d045a	ConditionSet: In doctests, do not rename ZZ^2 etc.
daeb91e	src/sage/sets/set.py: Fix docstring markup
2cf2199	Merge #32015
1eb270a	src/sage/docs/conf.py: Add more \ensuremath to \DeclareUnicodeCharacter
2682469	src/sage/interfaces/sympy_wrapper.py: Use Family, not Set, in doctests to make sure that the SageSet wrapper is actually used
753babb	Set_object_enumerated._sympy_: Translate empty sets to EmptySet
141ecde	Merge #32015
bf62543	Merge branch 't/32089/conditionset__conditionset_callable_symbolic_expression' into t/32009/eliminate_direct_use_of_the_chart__domain_attribute
ea08261	Merge #32009
3d1c44d	Merge tag '9.4.beta5' into t/32116/chart__parse_coordinates

[mkoeppe]

comment:13

Apparently this has been merged as part of #32089.