Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart-wise assumptions #32120

Open
mkoeppe opened this issue Jul 4, 2021 · 6 comments
Open

Chart-wise assumptions #32120

mkoeppe opened this issue Jul 4, 2021 · 6 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 4, 2021

(from #31901 comment:19)

The assumptions should not be global but chart-wise.

There is already a context manager assuming. We could create it at initialization and invoke it using with whenever computations are done with this chart.

We go through a new method assuming of CalculusMethod that dispatches in the same way as the simplify method does.

CC: @egourgoulhon @mjungmath

Component: manifolds

Issue created by migration from https://trac.sagemath.org/ticket/32120

@mkoeppe mkoeppe added this to the sage-9.4 milestone Jul 4, 2021
@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mjungmath
Copy link

comment:4

Another way could be to write a own class for the variables of a chart instead of seeing them as pure symbolic expressions. That could also solve the problem described in #30232.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 25, 2021

comment:5

I don't think that would help - assumptions are really per chart, not per variable; and in the end, they do need to be communicated to the symbolic engine.

@mjungmath
Copy link

comment:6

Replying to @mkoeppe:

not per variable; and in the end, they do need to be communicated to the symbolic engine.

That is indeed true.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 25, 2021

comment:7

Related to the discussion in #30232, perhaps it makes sense to introduce rings of expressions under symbolic assumptions. Simplifying an expression using an additional assumption would then be a coercion!

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 25, 2021

comment:8

(This is now #32276.)

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Mar 5, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 7, 2023
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants