-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove last mentions of database_gap #32189
Comments
New commits:
|
Branch: public/32189 |
Changed keywords from none to database_gap |
Commit: |
comment:2
ok, feu vert |
Reviewer: Frédéric Chapoton |
Changed branch from public/32189 to u/slelievre/32189 |
comment:3
Oops, typo "GAP uses needs" -> "GAP uses". New commits:
|
comment:4
Do you agree with these changes? |
comment:5
I don't think we need to leave this note. Could you give a little more justification of your rationale? If someone is jumping from 8.5, they will experience that many things have changed. I feel like this adds some clutter. Perhaps you could answer at which point should it be removed? |
Changed reviewer from Frédéric Chapoton to Frédéric Chapoton, Travis Scrimshaw |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:7
Removed the note that added clutter:
Please review. |
comment:8
Thank you. |
comment:9
Thank you for the review. |
Changed branch from u/slelievre/32189 to |
In #26856, all the GAP packages previously shipped
in the
database_gap
optional spkg were made partof the
gap
standard spkg, and thedatabase_gap
spkg was removed.
A few
# optional - database_gap
doctest tags wereinadvertently reintroduced in commit 3efc05e,
which appeared in #25902 and was adopted in #28782.
This ticket removes these doctest tags.
CC: @xcaruso @roed314 @slel @tscrim
Component: packages: standard
Keywords: database_gap
Author: Samuel Lelièvre
Branch/Commit:
6761700
Reviewer: Frédéric Chapoton, Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/32189
The text was updated successfully, but these errors were encountered: