Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last mentions of database_gap #32189

Closed
slel opened this issue Jul 12, 2021 · 18 comments
Closed

Remove last mentions of database_gap #32189

slel opened this issue Jul 12, 2021 · 18 comments

Comments

@slel
Copy link
Member

slel commented Jul 12, 2021

In #26856, all the GAP packages previously shipped
in the database_gap optional spkg were made part
of the gap standard spkg, and the database_gap
spkg was removed.

A few # optional - database_gap doctest tags were
inadvertently reintroduced in commit 3efc05e,
which appeared in #25902 and was adopted in #28782.

This ticket removes these doctest tags.

CC: @xcaruso @roed314 @slel @tscrim

Component: packages: standard

Keywords: database_gap

Author: Samuel Lelièvre

Branch/Commit: 6761700

Reviewer: Frédéric Chapoton, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32189

@slel slel added this to the sage-9.4 milestone Jul 12, 2021
@slel
Copy link
Member Author

slel commented Jul 12, 2021

New commits:

536c5f632189: Remove last database_gap mentions

@slel
Copy link
Member Author

slel commented Jul 12, 2021

Branch: public/32189

@slel
Copy link
Member Author

slel commented Jul 12, 2021

Changed keywords from none to database_gap

@slel
Copy link
Member Author

slel commented Jul 12, 2021

Commit: 536c5f6

@fchapoton
Copy link
Contributor

comment:2

ok, feu vert

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@slel
Copy link
Member Author

slel commented Jul 19, 2021

Changed commit from 536c5f6 to 8bca3c5

@slel
Copy link
Member Author

slel commented Jul 19, 2021

Changed branch from public/32189 to u/slelievre/32189

@slel
Copy link
Member Author

slel commented Jul 19, 2021

comment:3

Oops, typo "GAP uses needs" -> "GAP uses".
Let's also leave a note about TransGrp
being previously provided by "database_gap"
for the sake of users of Sage <= 8.5 reading
the online documentation.


New commits:

8bca3c532189: Remove last database_gap mentions

@slel
Copy link
Member Author

slel commented Jul 24, 2021

comment:4

Do you agree with these changes?

@tscrim
Copy link
Collaborator

tscrim commented Jul 26, 2021

comment:5

I don't think we need to leave this note. Could you give a little more justification of your rationale? If someone is jumping from 8.5, they will experience that many things have changed. I feel like this adds some clutter. Perhaps you could answer at which point should it be removed?

@tscrim
Copy link
Collaborator

tscrim commented Jul 26, 2021

Changed reviewer from Frédéric Chapoton to Frédéric Chapoton, Travis Scrimshaw

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 26, 2021

Changed commit from 8bca3c5 to 6761700

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 26, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

676170032189: Remove last database_gap mentions

@slel
Copy link
Member Author

slel commented Jul 26, 2021

comment:7

Removed the note that added clutter:

Up to Sage 8.5, "TransGrp" was available in Sage via the
"database_gap" optional Sage package, removed in :trac:`22626`
as its content became part of the "gap" standard Sage package.

Please review.

@tscrim
Copy link
Collaborator

tscrim commented Jul 26, 2021

comment:8

Thank you.

@slel
Copy link
Member Author

slel commented Jul 26, 2021

comment:9

Thank you for the review.

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Aug 9, 2021
@vbraun
Copy link
Member

vbraun commented Aug 31, 2021

Changed branch from u/slelievre/32189 to 6761700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants