Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.combinat, .matroids, .geometry: Fix use of MixedIntegerLinearProgram #32221

Closed
mkoeppe opened this issue Jul 17, 2021 · 9 comments
Closed

sage.combinat, .matroids, .geometry: Fix use of MixedIntegerLinearProgram #32221

mkoeppe opened this issue Jul 17, 2021 · 9 comments
Labels
c: combinatorics p: major / 3 t: bug
Milestone
sage-9.4

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 17, 2021

Part of #32191 (Meta-ticket: Audit/fix all uses of MixedIntegerLinearProgram in sage.combinat, sage.graphs)

sage.combinat.designs is taken care of in #32218

Depends on #32197

CC: @tscrim @dimpase @dcoudert

Component: combinatorics

Author: Matthias Koeppe

Branch/Commit: affdfab

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/32221
@mkoeppe mkoeppe added this to the sage-9.4 milestone Jul 17, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 17, 2021

Dependencies: #32197

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 17, 2021

Branch: u/mkoeppe/sage_combinat_sage_matroids_sage_geometry_fix_mip

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 17, 2021

Last 10 new commits:

cf16293MixedIntegerLinearProgram.get_values: Fix up for tolerance=None
5a74113MixedIntegerLinearProgram._backend_variable_value: Add docstring
aa4eed5MixedIntegerLinearProgram._backend_variable_value*: Add docstrings, examples
00b34aatrac #32197: review commit
db83853trac #32197: another review commit
0478c02gale_ryser_theorem: Fix use of MixedIntegerLinearProgram
a0777e8sage.combinat.matrices.dancing_links: Fix up use of MixedIntegerLinearProgram
7abadd0FinitePoset.dimension: Fix use of MixedIntegerLinearProgram
4f39706ConvexRationalPolyhedralCone.Hilbert_coefficients: Fix use of MixedIntegerLinearProgram
affdfabMatroid.flat_cover: Fix up use of MixedIntegerLinearProgram

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 17, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 17, 2021

Commit: affdfab

@dcoudert
Copy link
Contributor

Reviewer: David Coudert

@dcoudert
Copy link
Contributor

comment:5

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 18, 2021

comment:6

Thanks!

@vbraun
Copy link
Member

vbraun commented Jul 25, 2021

Changed branch from u/mkoeppe/sage_combinat_sage_matroids_sage_geometry_fix_mip to affdfab

@vbraun vbraun closed this as completed in 634276b Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.4
Development

No branches or pull requests
3 participants
@vbraun @mkoeppe @dcoudert