Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply "configure --enable-editable" also to other sage distribution packages #32713

Closed
tobiasdiez opened this issue Oct 18, 2021 · 15 comments
Closed

Comments

@tobiasdiez
Copy link
Contributor

Enables editable mode also for sage-conf, sage-docbuild, sage-setup.

CC: @mkoeppe

Component: build

Author: Tobias Diez

Branch: 7bd6ce4

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32713

@tobiasdiez tobiasdiez added this to the sage-9.5 milestone Oct 18, 2021
@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 18, 2021

comment:2

To match with the other functions in sage-dist-helpers, sdh_pip_editable_install should do its own error handling

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 18, 2021

Changed commit from b9b1dba to a257621

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 18, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

a257621Add error handling

@tobiasdiez
Copy link
Contributor Author

comment:4

Replying to @mkoeppe:

To match with the other functions in sage-dist-helpers, sdh_pip_editable_install should do its own error handling

Done

@tobiasdiez
Copy link
Contributor Author

comment:5

Do you have any further suggestions or can this go in?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 26, 2021

Changed commit from a257621 to 7bd6ce4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 26, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

89bc3eeMerge branch 'develop' of git://github.com/sagemath/sage into public/build/inplace_ext
7bd6ce4Partly revert "Enable editable mode also for other sage packages"

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 8, 2021

Reviewer: Matthias Koeppe

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 8, 2021

comment:7

This works well, thanks

@mkoeppe mkoeppe changed the title Enable editable mode also for other sage packages Apply "configure --enable-editable" also to other sage distribution packages Nov 8, 2021
@tobiasdiez
Copy link
Contributor Author

comment:8

Thanks for the review!

@vbraun
Copy link
Member

vbraun commented Nov 15, 2021

Changed branch from public/build/inplace_ext to 7bd6ce4

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 20, 2021

Changed commit from 7bd6ce4 to none

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 20, 2021

comment:11

Of course using --enable-editable now means that no sage_conf wheel is built any more! Which breaks tests such as ./sage -sh -c '(cd pkgs/sagemath-standard && tox -v -v -v -e python-sagewheels-nopypi)'.

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 20, 2021

comment:12

Followup = #32913.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants