Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exit code for pytest in case of no matched files #32892

Closed
tobiasdiez opened this issue Nov 17, 2021 · 3 comments
Closed

Fix exit code for pytest in case of no matched files #32892

tobiasdiez opened this issue Nov 17, 2021 · 3 comments
Labels
c: build p: major / 3 t: bug
Milestone
sage-9.5

Comments

@tobiasdiez
Copy link
Contributor

As reported in #31103 comment:44, sage -t xyz fails with exit code 5 if xyz matches no pytest tests. This is fixed.

CC: @mkoeppe @saraedum

Component: build

Author: Tobias Diez

Branch/Commit: 89b8754

Reviewer: Julian Rüth

Issue created by migration from https://trac.sagemath.org/ticket/32892
@tobiasdiez tobiasdiez added this to the sage-9.5 milestone Nov 17, 2021
@saraedum
Copy link
Member

Reviewer: Julian Rüth

@tobiasdiez
Copy link
Contributor Author

comment:3

Thanks for the quick review!

@vbraun
Copy link
Member

vbraun commented Dec 5, 2021

Changed branch from public/build/pytest-empty to 89b8754

@vbraun vbraun closed this as completed in e62f36a Dec 5, 2021
This was referenced Nov 22, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
4 participants
@saraedum @vbraun @tobiasdiez @mkoeppe