-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build/pkgs/sagelib: Invoke install cleaner explicitly, remove it from pkgs/sagemath-standard/setup.py #32927
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Author: Matthias Koeppe |
This comment has been minimized.
This comment has been minimized.
Commit: |
Last 10 new commits:
|
comment:9
Stalled in |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:14
Is this installing a nested package? The kind of stuff that we finally ditched with R/rpy a few years ago. |
comment:15
No, the distribution in |
comment:16
I think that may be best. But I must say so far I am a bit confused. I do not see where that "install-cleaner" is ever used. Is it just functionality you are keeping in reserve for now or for a dependent ticket? |
comment:23
Replying to @mkoeppe:
Oh yes I see. Like it says, that's not a bit I am usually concerned with downstream. |
comment:24
Yes, the only effect of this ticket on downstream packaging is that sagemath-standard's |
comment:25
If I was doing a bit of archeology on the sage-on-gentoo repo I think I would find bits where I suppressed some of that clean up. I seem to have let go of that part recently. |
Dependencies: #33855 |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Changed dependencies from #33855 to none |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Changed work issues from FIXME in build/pkgs/sagelib/spkg-install to Do not build_ext |
comment:34
Not needed with #32874 |
Dependencies: #32874 |
Changed author from Matthias Koeppe to none |
comment:35
Before we close this ticket, to clarify why this approach was abandoned, let me ask a couple of questions: Would Would If answers to both are yes, then the branch of this ticket could be an alternative to #32874? |
comment:36
Well, the branch here would have been a temporary solution, good enough until external packages arrive that fill the namespace |
comment:37
Okay. Thanks. |
Reviewer: Kwankyu Lee |
Unless
./configure --enable-editable
is used, the Sage library is installed directly intosite-packages
usingsetup.py install
, and at the end ofsage_setup
's customsage_install_and_clean
invokes the installation cleaner, which removes "stale" installed files.The installation cleaner is problematic when we start to install optional modules in the
sage.*
namespace via separate distributions such as sagemath-tdlib (#29864).pkgs/sagemath-standard/setup.py
will no longer enable optional Cython modules based on which optional packages are installedIn this ticket we solve this problem by removing the use of the installation cleaner from
pkgs/sagemath-standard/setup.py
. Instead we invoke it separately at the end of the installation scriptbuild/pkgs/sagelib/spkg-install
.(An alternative solution, replacing this installation procedure by a standard installation procedure using wheels, as proposed in #32874, would make
sage -b
much slower. Also, the idea of just making./configure --enable-editable
the default, #32406, has met skepticism.)Depends on #32874
CC: @kiwifb @jhpalmieri
Component: build
Work Issues: Do not build_ext
Branch/Commit: u/mkoeppe/pkgs_sagemath_standard_setup_py__move_distributions_logic_to_a_new_package_sagemath_optional @
edd0ea1
Reviewer: Kwankyu Lee
Issue created by migration from https://trac.sagemath.org/ticket/32927
The text was updated successfully, but these errors were encountered: