Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox / GH Actions: Fix docker-based tests after #31386 #33067

Closed
mkoeppe opened this issue Dec 22, 2021 · 17 comments
Closed

tox / GH Actions: Fix docker-based tests after #31386 #33067

mkoeppe opened this issue Dec 22, 2021 · 17 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 22, 2021

All docker-based tests are broken in 9.5.beta9 - https://github.com/sagemath/sage/actions/runs/1617032864

pkgs/ and src/*.m4 must be ADDed to the container already for the bootstrap phase so that files such as pkgs/sagemath-standard/setup.cfg are generated correctly.

This will fix this failures seen in https://github.com/mkoeppe/sage/runs/4602240946

Depends on #31386
Depends on #29039

CC: @dimpase @kliem

Component: porting

Author: Matthias Koeppe

Branch/Commit: 859be3e

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/33067

@mkoeppe mkoeppe added this to the sage-9.5 milestone Dec 22, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 22, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 22, 2021

Last 10 new commits:

82ce539configure.ac: If --disable-notebook and --disable-sagelib, do not build zeromq etc.
02505capkgs/sage-conf_pypi/MANIFEST.in: Update from #31396
aeca1a0Makefile (pypi-sdists): Add sage_setup
cd3dce9pkgs/sage-conf_pypi/setup.py: Update directory of configured sage_conf.py
c695921pkgs/sage-conf/sage_conf.py.in (SAGE_SPKG_WHEELS): Update so it works if SAGE_VENV != SAGE_LOCAL
cebcda3Merge tag '9.5.beta4' into t/29039/pip_installable_package_sage_bootstrap
0026892Merge tag '9.5.beta5' into t/29039/pip_installable_package_sage_bootstrap
2a4a323Merge tag '9.5.beta7' into t/29039/pip_installable_package_sage_bootstrap
02234ceMerge #29039
b1413d4build/bin/write-dockerfile.sh: Move 'ADD pkgs' earlier

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 22, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 22, 2021

Commit: b1413d4

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 22, 2021

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 22, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

4b5c599build/bin/write-dockerfile.sh: ADD src/*.m4 files for bootstrapping

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 22, 2021

Changed commit from b1413d4 to 4b5c599

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 22, 2021

Changed commit from 4b5c599 to 859be3e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 22, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

859be3ebuild/bin/write-dockerfile.sh: ADD src/*.m4 files for bootstrapping

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 22, 2021

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@dimpase
Copy link
Member

dimpase commented Dec 25, 2021

comment:9

lgtm

@dimpase
Copy link
Member

dimpase commented Dec 25, 2021

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/1612955038 to Dima Pasechnik

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 25, 2021

comment:10

Thanks!

@vbraun
Copy link
Member

vbraun commented Dec 29, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants