Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix doctest in quantum_group_gap #33148

Closed
fchapoton opened this issue Jan 11, 2022 · 15 comments
Closed

fix doctest in quantum_group_gap #33148

fchapoton opened this issue Jan 11, 2022 · 15 comments

Comments

@fchapoton
Copy link
Contributor

  • partial pep8 cleanup of this file

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: 130eb19

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/33148

@fchapoton fchapoton added this to the sage-9.5 milestone Jan 11, 2022
@fchapoton
Copy link
Contributor Author

New commits:

130eb19pep cleanup and doctest fix in quantum_group_gap

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/33148

@fchapoton
Copy link
Contributor Author

Commit: 130eb19

@orlitzky
Copy link
Contributor

comment:2

Isn't reversed(list(enumerate(... equivalent to reversed(enumerate(..., but slower?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 11, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

a4716f0simplify use of reversed

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 11, 2022

Changed commit from 130eb19 to a4716f0

@fchapoton
Copy link
Contributor Author

comment:4

true, thanks. Fixed now

@orlitzky
Copy link
Contributor

comment:5

Hi, sorry, I'm an idiot:

TypeError: 'enumerate' object is not reversible

You have to do sorted(enumerate(x), reverse=True), but I've done some testing and that's actually slower regardless of the size of your collection. So you can just drop that last commit. The rest looks good.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 11, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 11, 2022

Changed commit from a4716f0 to 130eb19

@fchapoton
Copy link
Contributor Author

comment:7

sorry, I should have run the doctests.. I dropped the last commit.

@orlitzky
Copy link
Contributor

comment:8

Replying to @fchapoton:

sorry, I should have run the doctests..

I did, not realizing they were all behind # optional tags...

@orlitzky
Copy link
Contributor

Reviewer: Michael Orlitzky

@slel
Copy link
Member

slel commented Jan 30, 2022

comment:10

Setting milestone to 9.6 now that 9.5 is out.

@slel slel modified the milestones: sage-9.5, sage-9.6 Jan 30, 2022
@vbraun
Copy link
Member

vbraun commented Feb 13, 2022

Changed branch from u/chapoton/33148 to 130eb19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants