use lazy_string() for string formatting when creating exceptions

[mezzarobba]

...to avoid eagerly calling costly _repr_() methods

Component: performance

Author: Marc Mezzarobba

Branch/Commit: 31dab22

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/33149

[mezzarobba]

Commit: 121e618

[mezzarobba]

Branch: u/mmezzarobba/33149-lazy_string

[mezzarobba]

New commits:

d2866ce	parent: systematically use _LazyString() with raise
a0407ba	qqbar: use lazy_string() with raise
121e618	{real,complex}_arb: use lazy_string() with raise

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8146241	parent: systematically use _LazyString() with raise
39525c9	qqbar: use lazy_string() with raise
7d79947	{real,complex}_arb: use lazy_string() with raise

[sagetrac-git]

Changed commit from 121e618 to 7d79947

[mezzarobba]

comment:4

rebased

[videlec]

comment:5

The patchbot says that you have at least the following problem

sage -t --long --random-seed=74790637899039575115911607402196642312 src/sage/geometry/cone.py
**********************************************************************
File "src/sage/geometry/cone.py", line 576, in sage.geometry.cone._ambient_space_point
Failed example:
    _ambient_space_point(c, vector(AA,[1/2,1/sqrt(3)]))
Exception raised:
    Traceback (most recent call last):
      File "/amd/compute/sagebot/sage/local/var/lib/sage/venv-python3.9.9/lib/python3.9/site-packages/sage/geometry/cone.py", line 606, in try_base_extend
        return L.base_extend(ring)(data)
      File "sage/structure/parent.pyx", line 897, in sage.structure.parent.Parent.__call__ (build/cythonized/sage/structure/parent.c:9445)
        return mor._call_(x)
      File "sage/structure/coerce_maps.pyx", line 161, in sage.structure.coerce_maps.DefaultConvertMap_unique._call_ (build/cythonized/sage/structure/coerce_maps.c:4729)
        raise
      File "sage/structure/coerce_maps.pyx", line 156, in sage.structure.coerce_maps.DefaultConvertMap_unique._call_ (build/cythonized/sage/structure/coerce_maps.c:4621)
        return C._element_constructor(x)
      File "/amd/compute/sagebot/sage/local/var/lib/sage/venv-python3.9.9/lib/python3.9/site-packages/sage/modules/free_module.py", line 5769, in _element_constructor_
        return FreeModule_generic_field._element_constructor_(self, e, *args, **kwds)
      File "/amd/compute/sagebot/sage/local/var/lib/sage/venv-python3.9.9/lib/python3.9/site-packages/sage/modules/free_module.py", line 1118, in _element_constructor_
        return self.element_class(self, x, coerce, copy)
      File "sage/modules/vector_rational_dense.pyx", line 151, in sage.modules.vector_rational_dense.Vector_rational_dense.__init__ (build/cythonized/sage/modules/vector_rational_dense.c:3749)
        z = Rational(x[i])
      File "sage/rings/rational.pyx", line 538, in sage.rings.rational.Rational.__init__ (build/cythonized/sage/rings/rational.cpp:6524)
        self.__set_value(x, base)
      File "sage/rings/rational.pyx", line 626, in sage.rings.rational.Rational.__set_value (build/cythonized/sage/rings/rational.cpp:7652)
        set_from_Rational(self, x._rational_())
      File "/amd/compute/sagebot/sage/local/var/lib/sage/venv-python3.9.9/lib/python3.9/site-packages/sage/rings/qqbar.py", line 5618, in _rational_
        raise ValueError(lazy_string(("Cannot coerce irrational Algebraic Real %s to Rational", self)))
    ValueError: <unprintable ValueError object>

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "/amd/compute/sagebot/sage/local/var/lib/sage/venv-python3.9.9/lib/python3.9/site-packages/sage/doctest/forker.py", line 694, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/amd/compute/sagebot/sage/local/var/lib/sage/venv-python3.9.9/lib/python3.9/site-packages/sage/doctest/forker.py", line 1088, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.geometry.cone._ambient_space_point[8]>", line 1, in <module>
        _ambient_space_point(c, vector(AA,[Integer(1)/Integer(2),Integer(1)/sqrt(Integer(3))]))
      File "/amd/compute/sagebot/sage/local/var/lib/sage/venv-python3.9.9/lib/python3.9/site-packages/sage/geometry/cone.py", line 628, in _ambient_space_point
        p = try_base_extend(ring)
      File "/amd/compute/sagebot/sage/local/var/lib/sage/venv-python3.9.9/lib/python3.9/site-packages/sage/geometry/cone.py", line 610, in try_base_extend
        if str(ex).startswith("Cannot coerce"):
      File "sage/misc/lazy_string.pyx", line 314, in sage.misc.lazy_string._LazyString.__str__ (build/cythonized/sage/misc/lazy_string.c:2632)
        return str(self.val())
      File "sage/misc/lazy_string.pyx", line 215, in sage.misc.lazy_string._LazyString.val (build/cythonized/sage/misc/lazy_string.c:2163)
        return PyObject_Call(f, self.args, self.kwargs)
    TypeError: 'tuple' object is not callable
**********************************************************************

[mezzarobba]

comment:6

Thank you! I wonder how I missed these failures...

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

3f3c7ed	parent: systematically use _LazyString() with raise
b990a55	qqbar: use lazy_string() with raise
31dab22	{real,complex}_arb: use lazy_string() with raise

[sagetrac-git]

Changed commit from 7d79947 to 31dab22

[videlec]

Reviewer: Vincent Delecroix

[vbraun]

Changed branch from u/mmezzarobba/33149-lazy_string to 31dab22