update Singular to 4.3.1 #33160

[sagemath_doc_html-none] // ** loaded /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/bin/../share/singular/LIB/freegb.lib (4.1.2.0,Feb_2019)
[sagemath_doc_html-none] // ** loaded /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/bin/../libexec/singular/MOD/freealgebra.so
[sagemath_doc_html-none] // ** loaded /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/bin/../share/singular/LIB/fpalgebras.lib (4.1.2.0,Feb_2019)
[sagemath_doc_html-none] // ** loaded /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/bin/../share/singular/LIB/general.lib (4.1.2.0,Feb_2019)
[sagemath_doc_html-none] // ** loaded /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/bin/../share/singular/LIB/ring.lib (4.1.2.0,Feb_2019)
[sagemath_doc_html-none] // ** loaded /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/bin/../share/singular/LIB/primdec.lib (4.2.1.1,Jul_2021)
[sagemath_doc_html-none] // ** loaded /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/bin/../share/singular/LIB/absfact.lib (4.1.2.0,Feb_2019)
[sagemath_doc_html-none] // ** loaded /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/bin/../share/singular/LIB/triang.lib (4.1.2.0,Feb_2019)
[sagemath_doc_html-none] // ** loaded /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/bin/../share/singular/LIB/random.lib (4.1.2.0,Feb_2019)
[sagemath_doc_html-none] // ** loaded /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/bin/../share/singular/LIB/elim.lib (4.1.2.0,Feb_2019)
[sagemath_doc_html-none] // ** loaded /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/bin/../share/singular/LIB/matrix.lib (4.1.2.0,Feb_2019)
[sagemath_doc_html-none] // ** loaded /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/bin/../share/singular/LIB/nctools.lib (4.1.2.0,Feb_2019)
[sagemath_doc_html-none] // ** loaded /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/bin/../share/singular/LIB/polylib.lib (4.2.0.0,Dec_2020)
[sagemath_doc_html-none] // ** loaded /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/bin/../share/singular/LIB/inout.lib (4.1.2.0,Feb_2019)
[sagemath_doc_html-none] // ** loaded /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/bin/../share/singular/LIB/qhmoduli.lib (4.1.2.0,Feb_2019)
[sagemath_doc_html-none] // ** loaded /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/bin/../share/singular/LIB/rinvar.lib (4.1.2.0,Feb_2019)
[sagemath_doc_html-none] // ** loaded /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/bin/../share/singular/LIB/zeroset.lib (4.1.2.0,Feb_2019)
[sagemath_doc_html-none] // ** loaded /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/bin/../share/singular/LIB/primitiv.lib (4.1.2.0,Feb_2019)
[sagemath_doc_html-none] // ** loaded /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/local/bin/../share/singular/LIB/presolve.lib (4.1.2.0,Feb_2019)
[sagemath_doc_html-none] ------------------------------------------------------------------------
[sagemath_doc_html-none] (no backtrace available)
[sagemath_doc_html-none] ------------------------------------------------------------------------
[sagemath_doc_html-none] Unhandled SIGSEGV: A segmentation fault occurred.
[sagemath_doc_html-none] This probably occurred because a *compiled* module has a bug
[sagemath_doc_html-none] in it and is not properly wrapped with sig_on(), sig_off().
[sagemath_doc_html-none] Python will now terminate.
[sagemath_doc_html-none] ------------------------------------------------------------------------
[sagemath_doc_html-none] /Users/mkoeppe/s/sage/sage-rebasing/worktree-gcc11/src/bin/sage-python: line 2: 90459 Segmentation fault: 11  sage -python "$@"
[sagemath_doc_html-none] make[6]: *** [doc-inventory--reference-algebras] Error 139

New commits:

`59c12fc`	`build/pkgs/singular: Update to 4.3.0`

fchapoton · 2022-01-24T14:54:59Z

comment:7

I have tried to launch an experimental patchbot on the ticket, and it fails, see the latest report's log. Not clear to me if this comes from a wrong experimental patchbot or from the singular update itself.

dimpase · 2022-01-24T15:15:32Z

comment:8

The bot should uninstall Singular it has installed, it seems.

The bot can check that the patch touches build/pkgs/FOOBAR/package-version.txt, and
run make FOOBAR-clean.

fchapoton · 2022-01-24T16:06:05Z

comment:9

I ran my bot twice on this ticket, that could be the reason why it did not re-build singular the second time. Still, why would it fail if the new singular is already built ?

A priori, no need to clean any package afterwards, the bot will just re-build any anterior version when testing another ticket. I can see a problem only when we ask the patchbot to build immediatly a different version of the same package with the same number. This should not happen so often.

dimpase · 2022-01-24T16:24:13Z

comment:10

Are you sure you have Singular 4.3.0 installed there? It might be just a confusing error message, and in fact you have 4.2.1 there (but probably not...).

Anyhow, a package upgrade must cause rebuild of everything that depends on it (e.g. sagelib in this case, and sagelib is not rebuilt (thus the error - libfactory-4.2.1, something from the older Singular version, is not found)).

fchapoton · 2022-01-24T17:28:42Z

comment:11

Thanks, indeed, something wrong happened.

Let me launch the bot again on this one, after testing another ticket.

fchapoton · 2022-01-24T17:41:26Z

comment:12

argh, once again building singular 4.3, but not sagelib..

EDIT: hmm, in fact, the log says it has built sagelib successfully

EDIT but it does not re-build pynac. Should this happen ?

dimpase · 2022-02-03T20:12:10Z

comment:14

Replying to @fchapoton:

argh, once again building singular 4.3, but not sagelib..

EDIT: hmm, in fact, the log says it has built sagelib successfully

EDIT but it does not re-build pynac. Should this happen ?

There is no more pynac spkg. It's merged into sagelib,
and lives in src/sage/symbolic/ginac/ and in src/sage/symbolic/

Could it be that some cython # distutils: declarations for dependent libfactory are missing somewhere
there? (it used to be taken care by the deps of pynac, cf. e.g. https://github.com/sagemath/sage-prod/blob/9.4/build/pkgs/pynac/dependencies).

mkoeppe · 2022-02-05T01:16:05Z

Dependencies: #33187

sagetrac-git · 2022-02-05T01:17:47Z

Changed commit from 59c12fc to 2bb054d

sagetrac-git · 2022-02-05T01:17:47Z

Branch pushed to git repo; I updated commit sha1. New commits:

`07bbd64`	`build/pkgs/{gcc,gfortran}/spkg-configure.m4: Accept 12.x`
`734ba23`	`build/pkgs/gcc/spkg-configure.m4: Reject GCC 4.9.x`
`35857d8`	`build/pkgs/singular: Add upstream PR 1128 for GCC 12 support`
`f27ff17`	`build/pkgs/giac/spkg-install.in: Use -std=gnu++11`
`2bb054d`	`Merge #33187`

mkoeppe · 2022-02-05T19:06:50Z

Changed dependencies from #33187 to #33187, #33296

sagetrac-git · 2022-02-05T19:07:14Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`e63b9f2`	`Merge tag '9.5' into t/31529/packages/texlive/add_spkg_configure_m4_and_system_package_information__remove_install_script`
`8b2490e`	`build/pkgs/texlive/spkg-configure.m4: ALso check for fncychap.sty`
`7b97dd4`	`update list of gentoo packages`
`016ff89`	`Merge #31529`
`855314d`	`src/doc/bootstrap: Get recommended spkg from build/pkgs/_recommended/dependencies`
`3164fff`	`build/pkgs/_recommended/dependencies: Add git`
`5e2cf42`	`Merge #33277`
`16f0197`	`tox.ini: New packages factor 'recommended'`
`7235c7b`	`.github/workflows/tox.yml: Switch docker workflows from -standard to -recommended`
`b1c692d`	`Merge #33296`

sagetrac-git · 2022-02-05T19:07:14Z

Changed commit from 2bb054d to b1c692d

sagetrac-git · 2022-02-05T19:25:42Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`b7fe1a7`	`Merge #33296`

sagetrac-git · 2022-02-05T19:25:42Z

Changed commit from b1c692d to b7fe1a7

dimpase · 2022-02-07T18:33:08Z

Changed dependencies from #33187, #33296 to #33187, #33296, #32211

mkoeppe · 2022-02-07T18:38:38Z

comment:24

I don't think #32211 is a dependency - Singular will still work with older versions of FLINT. (Otherwise, we would have to bump the minimal flint version in its spkg-configure...)

vbraun · 2022-07-18T19:47:27Z

comment:58

Well this ticket does indeed not build, so I once again waste my time on it.

mkoeppe · 2022-07-18T20:01:34Z

comment:60

Volker, can we get details please, or is your policy still to withhold this information in order to teach us a lesson?

dimpase · 2022-07-18T22:03:32Z

comment:61

I don't have a 32-bit builder, anyway.

vbraun · 2022-07-18T23:08:07Z

comment:62

Same failure that I previously reported on #33134

**********************************************************************
File "src/sage/rings/polynomial/hilbert.pyx", line 583, in sage.rings.polynomial.hilbert.hilbert_poincare_series
Failed example:
    J.hilbert_numerator(algorithm='singular')
Expected nothing
Got:
    overflow at t^22
    overflow at t^21
    overflow at t^20
    overflow at t^19
    overflow at t^18
    120*t^33 - 3465*t^32 + 48180*t^31 - 429374*t^30 + 2753520*t^29 - 13522410*t^28 + 52832780*t^27 - 168384150*t^26 + 445188744*t^25 - 987193350*t^24 + 1847488500*t^23 + 752776200*t^17 + 752776200*t^16 - 1580830020*t^15 + 1673936550*t^14 - 1294246800*t^13 + 786893250*t^12 - 382391100*t^11 + 146679390*t^10 - 42299400*t^9 + 7837830*t^8 - 172260*t^7 - 468930*t^6 + 183744*t^5 - 39270*t^4 + 5060*t^3 - 330*t^2 + 1
**********************************************************************

sagetrac-git · 2022-07-18T23:19:14Z

Changed commit from 83c0b03 to 6e9222d

sagetrac-git · 2022-07-18T23:19:14Z

Branch pushed to git repo; I updated commit sha1. New commits:

`8fe7620`	`build/pkgs/singular: Update to 4.3.0`
`c36a49b`	`build/pkgs/singular: Update to 4.3.0p1`
`4e69274`	`build/pkgs/singular/patches/1128.patch: Remove (upstreamed)`
`192efb2`	`build/pkgs/singular: Update to 4.3.1`
`ea08a04`	`src/sage/rings/polynomial/hilbert.pyx: Restrict a doctest to 64 bit`
`0679154`	`build/pkgs/singular: Update to 4.3.1p1`
`9b8e7cb`	`Trac #33134: add random (disabled) test for hilbert_numerator() algorithms.`
`83af1a8`	`add 32-bit catch-all case`
`6e9222d`	`Merge #33134`

mkoeppe · 2022-07-18T23:19:54Z

Changed author from Matthias Koeppe to Matthias Koeppe, Michael Orlitzky, Dima Pasechnik

mkoeppe · 2022-07-18T23:20:24Z

comment:65

I've merged in #33134 and edited that doctest slightly.

sagetrac-git · 2022-07-19T02:47:31Z

Changed commit from 6e9222d to 9cb5807

sagetrac-git · 2022-07-19T02:47:31Z

Branch pushed to git repo; I updated commit sha1. New commits:

`9cb5807`	`src/sage/rings/polynomial/hilbert.pyx: Final fix for the 32-bit result`

mkoeppe · 2022-07-19T02:48:23Z

comment:67

Tested successfully with tox -e docker-debian-buster-i386-standard.

mkoeppe · 2022-07-19T02:48:23Z

Changed reviewer from Dima Pasechnik to Dima Pasechnik, Matthias Koeppe

dimpase · 2022-07-19T07:37:42Z

comment:68

OK, also works (on 64-bit) with SAGE_CHECK=yes

vbraun · 2022-07-28T19:10:30Z

Changed branch from u/mkoeppe/update_singular_to_4_3_0 to 9cb5807

dimpase · 2022-10-21T12:43:25Z

comment:70

4.3.1p1 is broken on Fedora 34, as it does not have fstream.h (it does have fstream).
Reported upstream: Singular/Singular#1156

dimpase · 2022-10-21T12:43:25Z

Changed commit from 9cb5807 to none

dimpase added this to the sage-9.6 milestone Jan 13, 2022

dimpase added c: packages: standard labels Jan 13, 2022

This comment has been minimized.

Sign in to view

mkoeppe added p: critical / 2 and removed p: major / 3 labels Feb 1, 2022

This comment has been minimized.

Sign in to view

dimpase added the s: positive review label Jul 17, 2022

vbraun added s: needs work and removed s: positive review labels Jul 18, 2022

vbraun modified the milestones: sage-9.7, sage-9.8 Jul 18, 2022

mkoeppe added s: needs review and removed s: needs work labels Jul 18, 2022

mkoeppe modified the milestones: sage-9.8, sage-9.7 Jul 18, 2022

mkoeppe added s: positive review and removed s: needs review labels Jul 19, 2022

vbraun removed the s: positive review label Jul 28, 2022

vbraun closed this as completed in 79ed9e5 Jul 28, 2022

tornaria mentioned this issue Jul 29, 2022

doctest failure in hilbert_poincare_series with singular 4.2.1 #33134

Closed

update Singular to 4.3.1 #33160

update Singular to 4.3.1 #33160

Comments

dimpase commented Jan 13, 2022

This comment has been minimized.

This comment has been minimized.

mkoeppe commented Jan 23, 2022

mkoeppe commented Jan 23, 2022

mkoeppe commented Jan 23, 2022

fchapoton commented Jan 24, 2022

dimpase commented Jan 24, 2022

fchapoton commented Jan 24, 2022

dimpase commented Jan 24, 2022

fchapoton commented Jan 24, 2022

fchapoton commented Jan 24, 2022

dimpase commented Feb 3, 2022

mkoeppe commented Feb 5, 2022

sagetrac-git mannequin commented Feb 5, 2022

sagetrac-git mannequin commented Feb 5, 2022

mkoeppe commented Feb 5, 2022

sagetrac-git mannequin commented Feb 5, 2022

sagetrac-git mannequin commented Feb 5, 2022

This comment has been minimized.

sagetrac-git mannequin commented Feb 5, 2022

sagetrac-git mannequin commented Feb 5, 2022

This comment has been minimized.

dimpase commented Feb 7, 2022

mkoeppe commented Feb 7, 2022

vbraun commented Jul 18, 2022

mkoeppe commented Jul 18, 2022

dimpase commented Jul 18, 2022

vbraun commented Jul 18, 2022

sagetrac-git mannequin commented Jul 18, 2022

sagetrac-git mannequin commented Jul 18, 2022

mkoeppe commented Jul 18, 2022

mkoeppe commented Jul 18, 2022

sagetrac-git mannequin commented Jul 19, 2022

sagetrac-git mannequin commented Jul 19, 2022

mkoeppe commented Jul 19, 2022

mkoeppe commented Jul 19, 2022

dimpase commented Jul 19, 2022

vbraun commented Jul 28, 2022

dimpase commented Oct 21, 2022

dimpase commented Oct 21, 2022