Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix E111 (indentation) in rings #33334

Closed
fchapoton opened this issue Feb 13, 2022 · 6 comments
Closed

fix E111 (indentation) in rings #33334

fchapoton opened this issue Feb 13, 2022 · 6 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.6

Comments

@fchapoton
Copy link
Contributor

except in two files

src/sage/rings/polynomial/convolution.py
src/sage/rings/polynomial/toy_variety.py

that need special care, as they seem to use indentation by 2 spaces

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: dbc17f8

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/33334
@fchapoton fchapoton added this to the sage-9.6 milestone Feb 13, 2022
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/33334

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 13, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

dbc17f8fix indentation E111 in rings/

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 13, 2022

Commit: dbc17f8

@tscrim
Copy link
Collaborator

tscrim commented Feb 14, 2022

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Feb 14, 2022

comment:3

LGTM.

@vbraun
Copy link
Member

vbraun commented Feb 21, 2022

Changed branch from u/chapoton/33334 to dbc17f8

@vbraun vbraun closed this as completed in aa255bf Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.6
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton