-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nbconvert to 6.4.x, add optional package pyppeteer #33533
Comments
Commit: |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Author: Matthias Koeppe |
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:6
Then we need a discussion on sage-devel? |
comment:7
No, we have routinely added new dependencies of standard packages as standard packages on upgrades in the past |
comment:8
LGTM. |
Reviewer: Kwankyu Lee |
comment:9
Thanks! |
comment:10
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
New commits:
|
comment:14
The prefix |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:16
The issue is now resolved. Back to positive review. |
comment:17
Thanks! |
Changed branch from u/mkoeppe/update_nbconvert_to_6_4_x__add_optional_package_pyppeteer to |
The update to 6.4.x (https://nbconvert.readthedocs.io/en/latest/changelog.html) brings some improvements to webpdf exports.
6.4.x (and main as of 2022-03) still supports python 3.7, as needed for Sage 9.6
There is a new dependency,
beautifulsoup4
. We convert the existing pip package to a standard normal package.The new package Pyppeteer is needed for webpdf exports of Jupyter notebooks.
pyppeteer has a number of new dependencies, so for now we only add it as a pip package.
CC: @kwankyu
Component: packages: standard
Author: Matthias Koeppe
Branch/Commit:
6219340
Reviewer: Kwankyu Lee
Issue created by migration from https://trac.sagemath.org/ticket/33533
The text was updated successfully, but these errors were encountered: