Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nbconvert to 6.4.x, add optional package pyppeteer #33533

Closed
mkoeppe opened this issue Mar 20, 2022 · 24 comments
Closed

Update nbconvert to 6.4.x, add optional package pyppeteer #33533

mkoeppe opened this issue Mar 20, 2022 · 24 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 20, 2022

The update to 6.4.x (https://nbconvert.readthedocs.io/en/latest/changelog.html) brings some improvements to webpdf exports.

6.4.x (and main as of 2022-03) still supports python 3.7, as needed for Sage 9.6

There is a new dependency, beautifulsoup4. We convert the existing pip package to a standard normal package.

The new package Pyppeteer is needed for webpdf exports of Jupyter notebooks.

pyppeteer has a number of new dependencies, so for now we only add it as a pip package.

CC: @kwankyu

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: 6219340

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/33533

@mkoeppe mkoeppe added this to the sage-9.6 milestone Mar 20, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 27, 2022

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 27, 2022

Commit: 652d823

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 27, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

652d823build/pkgs/pyppeteer: New pip package

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 27, 2022

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 27, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

2c8fd61configure.ac (--disable-notebook): Also disable beautifulsoup4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 27, 2022

Changed commit from 652d823 to 2c8fd61

@kwankyu
Copy link
Collaborator

kwankyu commented Mar 28, 2022

comment:6

We convert the existing pip package to a standard normal package.

Then we need a discussion on sage-devel?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 28, 2022

comment:7

No, we have routinely added new dependencies of standard packages as standard packages on upgrades in the past

@kwankyu
Copy link
Collaborator

kwankyu commented Mar 29, 2022

comment:8

LGTM.

@kwankyu
Copy link
Collaborator

kwankyu commented Mar 29, 2022

Reviewer: Kwankyu Lee

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 29, 2022

comment:9

Thanks!

@vbraun
Copy link
Member

vbraun commented Mar 31, 2022

comment:10
sage -t --long --warn-long 48.1 --random-seed=123 src/sage/misc/package.py
**********************************************************************
File "src/sage/misc/package.py", line 564, in sage.misc.package.optional_packages
Failed example:
    'beautifulsoup4' in installed+not_installed  # optional - sage_spkg
Expected:
    True
Got:
    False
**********************************************************************
1 item had failures:
   1 of   4 in sage.misc.package.optional_packages
    [56 tests, 1 failure, 3.67 s]
----------------------------------------------------------------------
sage -t --long --warn-long 48.1 --random-seed=123 src/sage/misc/package.py  # 1 doctest failed
----------------------------------------------------------------------

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 31, 2022

Changed commit from 2c8fd61 to b6172cf

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 31, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

b6172cfsrc/sage/misc/package.py: Use biopython instead of beautifulsoup4 as an example for pip packages

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 31, 2022

Changed commit from b6172cf to 02f166e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 31, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

02f166esrc/sage/misc/package.py: Use biopython instead of beautifulsoup4 as an example for pip packages

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 31, 2022

New commits:

02f166esrc/sage/misc/package.py: Use biopython instead of beautifulsoup4 as an example for pip packages

@kwankyu
Copy link
Collaborator

kwankyu commented Apr 1, 2022

comment:14

The prefix bs4 also needs to be changed to bp?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 1, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

6219340src/sage/misc/package.py: Cosmetic change in doctest

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 1, 2022

Changed commit from 02f166e to 6219340

@kwankyu
Copy link
Collaborator

kwankyu commented Apr 1, 2022

comment:16

The issue is now resolved. Back to positive review.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 1, 2022

comment:17

Thanks!

@vbraun
Copy link
Member

vbraun commented Apr 3, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants