Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of #py2 outside of explain_pickle #33535

Closed
fchapoton opened this issue Mar 20, 2022 · 8 comments
Closed

get rid of #py2 outside of explain_pickle #33535

fchapoton opened this issue Mar 20, 2022 · 8 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.6

Comments

@fchapoton
Copy link
Contributor

for the remaining ones in explain_pickle, see #33144

CC: @tscrim @slel @kliem

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 683eed9

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/33535
@fchapoton fchapoton added this to the sage-9.6 milestone Mar 20, 2022
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/33535

@fchapoton
Copy link
Contributor Author

New commits:

683eed9get rid of #py2 outside of explain_pickle

@fchapoton
Copy link
Contributor Author

Commit: 683eed9

@fchapoton

This comment has been minimized.

Sign in to view
@fchapoton
Copy link
Contributor Author

comment:3

green bot, so please review

@tscrim
Copy link
Collaborator

tscrim commented Mar 20, 2022

comment:4

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Mar 20, 2022

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Mar 27, 2022

Changed branch from u/chapoton/33535 to 683eed9

@vbraun vbraun closed this as completed in fef33af Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.6
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton