Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move method distance_graph to graph.py #33776

Closed
dcoudert opened this issue Apr 30, 2022 · 8 comments
Closed

move method distance_graph to graph.py #33776

dcoudert opened this issue Apr 30, 2022 · 8 comments
Labels
c: graph theory p: major / 3 t: enhancement
Milestone
sage-9.7

Comments

@dcoudert
Copy link
Contributor

Method distance_graph, introduced in #7533, has been designed for undirected graphs (see #7533 comment:3) and moved to generic_graph.py in #7634 without care for directed graphs.

In this ticket, we move distance_graph to graph.py and improve it.

We let open the design of an adequate method for directed graphs and the extension to weighted (di)graphs.

CC: @tscrim

Component: graph theory

Author: David Coudert

Branch/Commit: 1edf47a

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/33776
@dcoudert dcoudert added this to the sage-9.7 milestone Apr 30, 2022
@dcoudert
Copy link
Contributor Author

New commits:

8e7548btrac #33776: move distance_graph to graph.py
f715576trac #33776: speed up
1edf47atrac #33776: some care

@dcoudert

This comment has been minimized.

Sign in to view
@dcoudert
Copy link
Contributor Author

Commit: 1edf47a

@dcoudert
Copy link
Contributor Author

Branch: public/graphs/33776

@tscrim
Copy link
Collaborator

tscrim commented Jun 10, 2022

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jun 10, 2022

comment:2

LGTM.

@dcoudert
Copy link
Contributor Author

comment:3

Thank you

@vbraun
Copy link
Member

vbraun commented Jun 12, 2022

Changed branch from public/graphs/33776 to 1edf47a

@vbraun vbraun closed this as completed in 6b6f0cf Jun 12, 2022
@mo271 mo271 mentioned this issue Jan 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
3 participants
@vbraun @tscrim @dcoudert