Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci-cygwin: Refactor using reusable workflows #33791

Closed
mkoeppe opened this issue May 3, 2022 · 38 comments
Closed

ci-cygwin: Refactor using reusable workflows #33791

mkoeppe opened this issue May 3, 2022 · 38 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented May 3, 2022

We refactor ci-cygwin-standard.yml using the new reusable workflow cygwin.yml (see https://docs.github.com/en/actions/using-workflows/reusing-workflows for this new GH Actions feature).

We also remove ci-cygwin-minimal.yml; this configuration has not run successfully for a long time, and there is no expectation that it will be fixed.

The workflow includes optional steps that are useful for upstream CIs. First uses:

Depends on #33782

CC: @dimpase @kliem @tobiasdiez

Component: porting: Cygwin

Author: Matthias Koeppe

Branch: e221c50

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/33791

@mkoeppe mkoeppe added this to the sage-9.6 milestone May 3, 2022
@mkoeppe
Copy link
Member Author

mkoeppe commented May 3, 2022

Dependencies: #33782

@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 May 3, 2022
@mkoeppe
Copy link
Member Author

mkoeppe commented May 3, 2022

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 3, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

f8f5d5d.github/workflows/ci-cygwin-standard.yml: Remove continue-on-error

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 3, 2022

Commit: f8f5d5d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 3, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

b6986e0.github/workflows/cygwin.yml: Fixup

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 3, 2022

Changed commit from f8f5d5d to b6986e0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 3, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

147797e.github/workflows/cygwin.yml: Fixup

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 3, 2022

Changed commit from b6986e0 to 147797e

@mkoeppe
Copy link
Member Author

mkoeppe commented May 3, 2022

@mkoeppe
Copy link
Member Author

mkoeppe commented May 3, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented May 3, 2022

Work Issues: Generalize so it can be used upstream - https://github.com/kimwalisch/primecount/blob/master/.github/workflows/ci-sage.yml

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 3, 2022

Changed commit from 147797e to d86ac05

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 3, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

d86ac05.github/workflows/cygwin.yml: Add steps for upstream CIs

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 3, 2022

Changed commit from d86ac05 to 390b366

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 3, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

390b366.github/workflows/cygwin.yml: Add steps for upstream CIs

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 3, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

eb60dc1.github/workflows/cygwin.yml: Add steps for upstream CIs

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 3, 2022

Changed commit from 390b366 to eb60dc1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 3, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

350509d.github/workflows/cygwin.yml: Pass on targets_pre, targets_optional
d9a66a2.github/workflows/cygwin.yml: Use correct shell when preparing logs artifact

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 3, 2022

Changed commit from eb60dc1 to d9a66a2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 4, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

4c5715f.github/workflows/cygwin.yml: Handle inputs.prefix

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 4, 2022

Changed commit from d9a66a2 to 4c5715f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 4, 2022

Changed commit from 4c5715f to aa88608

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 4, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

aa88608.github/workflows/cygwin.yml: Handle inputs.prefix

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 4, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

58efcb9.github/workflows/cygwin.yml: Handle inputs.prefix

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 4, 2022

Changed commit from aa88608 to 58efcb9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 4, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

a51790c.github/workflows/cygwin.yml: Fix quoting

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 4, 2022

Changed commit from 58efcb9 to a51790c

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Member Author

mkoeppe commented May 4, 2022

Changed work issues from Generalize so it can be used upstream - https://github.com/kimwalisch/primecount/blob/master/.github/workflows/ci-sage.yml to none

@mkoeppe

This comment has been minimized.

@dimpase
Copy link
Member

dimpase commented Jun 29, 2022

Changed reviewer from https://github.com/sagemath/sagetrac-mirror/actions/runs/2268082239 to Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Jun 29, 2022

comment:18

lgtm

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 29, 2022

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:

0d7bfe8.github/workflows: Refactor ci-cygwin-standard.yml through cygwin.yml, remove ci-cygwin-minimal.yml
3cf7ea6.github/workflows/ci-cygwin-standard.yml: Remove continue-on-error
bacba6b.github/workflows/cygwin.yml: Fixup
5c8e570.github/workflows/cygwin.yml: Add steps for upstream CIs
8921487.github/workflows/cygwin.yml: Pass on targets_pre, targets_optional
fb61ebc.github/workflows/cygwin.yml: Use correct shell when preparing logs artifact
0ac57e1.github/workflows/cygwin.yml: Handle inputs.prefix
5e52c96.github/workflows/cygwin.yml: Fix quoting
e221c50.github/workflows/cygwin.yml: Use inputs.sage_trac_ticket

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 29, 2022

Changed commit from a51790c to e221c50

@mkoeppe
Copy link
Member Author

mkoeppe commented Jun 29, 2022

comment:20

Thanks! I've added another small fix

@vbraun
Copy link
Member

vbraun commented Jul 9, 2022

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 7, 2022

Changed commit from e221c50 to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants