Meta-ticket: Remove runtime dependency on everything via sage_eval

[mkoeppe]

sage_eval evaluates a string using the globals of sage.all.

It is used in some constructors and other functions - but in most uses, likely just a few bindings, namely those emitted by the preparser, are needed. We create a module sage.repl.preparse_bindings for these bindings (Ellipsis, ellipsis_range, ellipsis_iter, Integer, RealNumber, ComplexNumber, var, symbolic_expression, ...)

It is also used by sage_input to verify inputs. We run the verification with a smaller module first before falling back to sage.all

Tickets:

• get rid of one sage_eval in complex numbers #38391
• get rid of sage_eval in grobner_fan #38392
• get rid of one sage_eval in modular #38394
• get rid of some sage-eval in gap3-related code #38395
• get rid of sage_eval in cfinite_sequence #38462
• simplify conversion code in cubic Hecke #38458

See also:

• conversion of string to complex number with sage_eval should be avoided #30977, sage_input is unreliable for elements of ComplexField #32129, conversion of string 'r' in fraction field #26155 - issues with sage_eval, sage_input
• Stop using old_style_globals #18083 Stop using old_style_globals

CC: @kwankyu @kliem @jhpalmieri @spaghettisalat @jcamp0x2a

Component: refactoring

Branch/Commit: u/mkoeppe/remove_runtime_dependency_on_everything_via_sage_eval @ 3552523

Issue created by migration from https://trac.sagemath.org/ticket/33802

[mkoeppe]

Branch: u/mkoeppe/remove_runtime_dependency_on_everything_via_sage_eval

[mkoeppe]

Commit: 3552523

[mkoeppe]

comment:4

With this change:

diff --git a/src/sage/misc/sage_eval.py b/src/sage/misc/sage_eval.py
index ebd9ad6f3d..57419a8ba9 100644
--- a/src/sage/misc/sage_eval.py
+++ b/src/sage/misc/sage_eval.py
@@ -182,7 +182,13 @@ def sage_eval(source, locals=None, cmds='', preparse=True):
     if locals is None:
         locals = {}
 
-    import sage.all
+    if cmds:
+        import sage.all
+        globals = sage.all.__dict__
+    else:
+        import sage.repl.preparse_expression_runtime
+        globals = sage.repl.preparse_expression_runtime.__dict__
+
     if cmds:
         cmd_seq = cmds + '\n_sage_eval_returnval_ = ' + source
         if preparse:
@@ -192,10 +198,10 @@ def sage_eval(source, locals=None, cmds='', preparse=True):
             source = preparser.preparse(source)
 
     if cmds:
-        exec(cmd_seq, sage.all.__dict__, locals)
+        exec(cmd_seq, globals, locals)
         return locals['_sage_eval_returnval_']
     else:
-        return eval(source, sage.all.__dict__, locals)
+        return eval(source, globals, locals)
 

there are only a few failures (except for growth_group.py)

$ ./sage -tp $(git grep -l sage_eval)
....
sage -t --random-seed=131777733077912989056233344518802251877 src/sage/rings/asymptotic/growth_group.py  # 460 doctests failed
sage -t --random-seed=131777733077912989056233344518802251877 src/sage/rings/polynomial/polynomial_element.pyx  # 3 doctests failed
sage -t --random-seed=131777733077912989056233344518802251877 src/sage/rings/complex_mpfr.pyx  # 3 doctests failed
sage -t --random-seed=131777733077912989056233344518802251877 src/sage/matrix/matrix1.pyx  # 6 doctests failed
sage -t --random-seed=131777733077912989056233344518802251877 src/sage/misc/sage_eval.py  # 3 doctests failed
sage -t --random-seed=131777733077912989056233344518802251877 src/sage/rings/polynomial/multi_polynomial_ring.py  # 1 doctest failed
sage -t --random-seed=131777733077912989056233344518802251877 src/sage/rings/asymptotic/misc.py  # 21 doctests failed
sage -t --random-seed=131777733077912989056233344518802251877 src/sage/symbolic/units.py  # 2 doctests failed

---

New commits:

3552523

src/sage/repl/preparse_expression_runtime.py: New