Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc-build.yml: Set NETLIFY_ALIAS to the tag name #33862

Open
mkoeppe opened this issue May 17, 2022 · 9 comments
Open

doc-build.yml: Set NETLIFY_ALIAS to the tag name #33862

mkoeppe opened this issue May 17, 2022 · 9 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented May 17, 2022

From sagemath/documentation#24 (comment)

When the workflow is invoked on GITHUB_REF of the form refs/tags/TAG_NAME, set NETLIFY_ALIAS=TAG_NAME. The resulting URL can then be referred to in a redirect rule. sagemath/documentation#24 (comment)

CC: @tobiasdiez @haraldschilly @dimpase

Component: website/wiki

Author: Matthias Koeppe

Branch/Commit: u/mkoeppe/doc_build_yml__set_netlify_alias_to_the_tag_name @ b786c07

Issue created by migration from https://trac.sagemath.org/ticket/33862

@mkoeppe mkoeppe added this to the sage-9.7 milestone May 17, 2022
@mkoeppe
Copy link
Member Author

mkoeppe commented May 17, 2022

@mkoeppe
Copy link
Member Author

mkoeppe commented May 17, 2022

comment:2

Untested, help welcome


New commits:

b786c07.github/workflows/doc-build.yml: For tags, set NETLIFY_ALIAS to the tag name

@mkoeppe
Copy link
Member Author

mkoeppe commented May 17, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented May 17, 2022

Commit: b786c07

@mkoeppe
Copy link
Member Author

mkoeppe commented May 17, 2022

comment:3

Still works for non-tag invocations of the workflow.

@tobiasdiez
Copy link
Contributor

comment:4

I don't think this works for the following reasons:

@mkoeppe
Copy link
Member Author

mkoeppe commented May 18, 2022

comment:5

Good catch.

@mkoeppe
Copy link
Member Author

mkoeppe commented May 18, 2022

comment:7

Should we run it on sagemath/sage then for release tags?

@tobiasdiez
Copy link
Contributor

comment:8

I don't know. It's still not clear to me why there are actually two github mirrors/repos and what should be run where.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants