Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some better .join with iterator inside #33956

Closed
fchapoton opened this issue Jun 5, 2022 · 9 comments
Closed

some better .join with iterator inside #33956

fchapoton opened this issue Jun 5, 2022 · 9 comments
Labels
p: minor / 4 t: enhancement t: refactoring
Milestone
sage-9.7

Comments

@fchapoton
Copy link
Contributor

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: aa7d2e4

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/33956
@fchapoton fchapoton added this to the sage-9.7 milestone Jun 5, 2022
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/33956

@fchapoton
Copy link
Contributor Author

Commit: aa7d2e4

@fchapoton
Copy link
Contributor Author

New commits:

aa7d2e4some better .join with no list inside

@dcoudert
Copy link
Contributor

dcoudert commented Jun 5, 2022

comment:2

These changes looks good to me. However, the reported pyflakes errors are potential bugs and certainly deserves dedicated tickets.

@dcoudert
Copy link
Contributor

dcoudert commented Jun 5, 2022

Reviewer: David Coudert

@fchapoton
Copy link
Contributor Author

comment:3

Salut,

le fichier "src/sage/graphs/graph_database.py" est en déshérence totale, abandonné par tout le monde depuis longtemps..

@dcoudert
Copy link
Contributor

dcoudert commented Jun 6, 2022

comment:4

Je me demande si des gens utilisent...

@dcoudert
Copy link
Contributor

dcoudert commented Jun 6, 2022

comment:5

LGTM.

@vbraun
Copy link
Member

vbraun commented Jun 12, 2022

Changed branch from u/chapoton/33956 to aa7d2e4

@vbraun vbraun closed this as completed in b3d6a0b Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: minor / 4 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @dcoudert