Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __reversed__ method to FrozenBitsets #34035

Closed
trevorkarn opened this issue Jun 20, 2022 · 4 comments
Closed

Add __reversed__ method to FrozenBitsets #34035

trevorkarn opened this issue Jun 20, 2022 · 4 comments

Comments

@trevorkarn
Copy link
Contributor

One can currently iterate over the elements of a FrozenBitset, but only in the forward direction. This ticket fixes that.

CC: @tscrim @jasongrout

Component: misc

Keywords: gsoc2022 frozenbitset iteration reversed

Author: Trevor K. Karn

Branch/Commit: d4f3d86

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34035

@trevorkarn trevorkarn added this to the sage-9.7 milestone Jun 20, 2022
@trevorkarn
Copy link
Contributor Author

comment:2

cc'ing Jason as original author.

@tscrim
Copy link
Collaborator

tscrim commented Jun 21, 2022

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jun 21, 2022

comment:3

This will work for now, although both this and the iterator would be better to not create the whole list and then iterate over it (more important for large bitsets). Although for the reversed, this would be much harder to do than the forward iterator.

@vbraun
Copy link
Member

vbraun commented Jun 28, 2022

Changed branch from u/tkarn/reverse-frozenbitset to d4f3d86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants