Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve symbolic operators documentation #34128

Closed
tdupu mannequin opened this issue Jul 7, 2022 · 8 comments
Closed

Improve symbolic operators documentation #34128

tdupu mannequin opened this issue Jul 7, 2022 · 8 comments

Comments

@tdupu
Copy link
Mannequin

tdupu mannequin commented Jul 7, 2022

In Sage 9.7.beta8, the docstring for the parameter_set
method of function derivative operators has an example
but no description.

To see this:

sage: y = function('y')(x)
sage: yd = diff(y, x)
sage: op = yd.operator()
sage: op.parameter_set?
Signature:      op.parameter_set()
Docstring:
   EXAMPLES:

      sage: from sage.symbolic.operators import FDerivativeOperator
      sage: f = function('foo')
      sage: op = FDerivativeOperator(f, [0,1])
      sage: op.parameter_set()
      [0, 1]
Init docstring: Initialize self.  See help(type(self)) for accurate signature.
File:           .../sage/symbolic/operators.py
Type:           method}}}

The regulations for documentation strings can be found here:

CC: @slel

Component: documentation

Author: Samuel Lelièvre

Branch/Commit: 27579d6

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34128

@tdupu tdupu mannequin added this to the sage-9.7 milestone Jul 7, 2022
@tdupu tdupu mannequin added c: documentation labels Jul 7, 2022
@slel

This comment has been minimized.

@slel
Copy link
Member

slel commented Aug 16, 2022

comment:1

Thanks for the report. Here is a tentative improvement. Please review.


New commits:

27579d634128: Improve documentation of symbolic operators

@slel
Copy link
Member

slel commented Aug 16, 2022

Branch: u/slelievre/34128

@slel
Copy link
Member

slel commented Aug 16, 2022

Author: Samuel Lelièvre

@slel
Copy link
Member

slel commented Aug 16, 2022

Commit: 27579d6

@slel slel changed the title Documentation String for /sage/symbolic/operators.py Improve symbolic operators documentation Aug 16, 2022
@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 16, 2022

comment:2

LGTM

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 16, 2022

Reviewer: Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented Aug 30, 2022

Changed branch from u/slelievre/34128 to 27579d6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants