Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the quantum Clifford algebra at a root of unity #34147

Closed
tscrim opened this issue Jul 11, 2022 · 23 comments
Closed

Implement the quantum Clifford algebra at a root of unity #34147

tscrim opened this issue Jul 11, 2022 · 23 comments

Comments

@tscrim
Copy link
Collaborator

tscrim commented Jul 11, 2022

This works for sufficiently large roots of unity: when q2k != 1. We provide a new implementation/basis when this q2k = 1.

CC: @fchapoton

Component: algebra

Keywords: quantum Clifford

Author: Travis Scrimshaw

Branch/Commit: 40aab1e

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/34147

@tscrim tscrim added this to the sage-9.7 milestone Jul 11, 2022
@tscrim
Copy link
Collaborator Author

tscrim commented Jul 11, 2022

comment:1

A bit of refactoring to have some good programming practices. I also fixed a bug in the inverse not taking into account the coefficients and will use the (new-ish) general inverse code to check the generic case.


New commits:

6ef8f5fImplementing the quantum Clifford at a root of unity.
e29f119Use the generic inverse code when not a special case of a monomial.

@tscrim
Copy link
Collaborator Author

tscrim commented Jul 11, 2022

@tscrim
Copy link
Collaborator Author

tscrim commented Jul 11, 2022

Commit: e29f119

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 12, 2022

Changed commit from e29f119 to 2f7cd21

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 12, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

4f7107eMerge branch 'develop' into public/algebras/quantum_clifford_root_unity-34147
2f7cd21Fixing the quantum Clifford doc.

@fchapoton
Copy link
Contributor

comment:3

please avoid using except Exception

otherwise looks good

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 14, 2022

Changed commit from 2f7cd21 to 07ffd7a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 14, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

07ffd7aDo not catch any exceptions; just let it fail.

@tscrim
Copy link
Collaborator Author

tscrim commented Jul 14, 2022

comment:5

Replying to @fchapoton:

please avoid using except Exception

I couldn't figure out which exceptions to actually catch, so I decided to just let it fail.

(BTW, this type of catching is done elsewhere in Sage. What is your suggestion for catching exceptions when you want to catch basically all of them?)

@fchapoton
Copy link
Contributor

comment:6

here you may want to use the method .fraction_field and catch AttributeError

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 15, 2022

Changed commit from 07ffd7a to 5b55aa0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 15, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

5b55aa0Use the FractionField function instead.

@tscrim
Copy link
Collaborator Author

tscrim commented Jul 15, 2022

comment:8

Replying to @fchapoton:

here you may want to use the method .fraction_field and catch AttributeError

Fair point. I decided to use the FractionField function instead since that has a few other sageguards.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 2, 2022

Changed commit from 5b55aa0 to 6f15344

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 2, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

6f15344Merge branch 'develop' into public/algebras/quantum_clifford_root_unity-34147

@fchapoton
Copy link
Contributor

comment:10

linter badge says

sage/algebras/quantum_clifford.py:699:9: E306 expected 1 blank line before a nested definition, found 0
sage/algebras/quantum_clifford.py:738:9: E306 expected 1 blank line before a nested definition, found 0
2       E306 expected 1 blank line before a nested definition, found 0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 7, 2022

Changed commit from 6f15344 to 40aab1e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 7, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

40aab1eAdded whitespace for E306.

@tscrim
Copy link
Collaborator Author

tscrim commented Aug 7, 2022

comment:12

Fixed.

@fchapoton
Copy link
Contributor

comment:13

ok, then let it be.

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@tscrim
Copy link
Collaborator Author

tscrim commented Aug 7, 2022

comment:14

Thank you!

@vbraun
Copy link
Member

vbraun commented Aug 29, 2022

Changed branch from public/algebras/quantum_clifford_root_unity-34147 to 40aab1e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants