Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta ticket: fix docstring markups #34157

Closed
kwankyu opened this issue Jul 12, 2022 · 63 comments
Closed

Meta ticket: fix docstring markups #34157

kwankyu opened this issue Jul 12, 2022 · 63 comments

Comments

@kwankyu
Copy link
Collaborator

kwankyu commented Jul 12, 2022

Originated from #30448.

We fix

https://github.com/sagemath/sagetrac-mirror/runs/7294638131?check_suite_focus=true

by chunks through

and a few commits that finish the job here on the ticket.

Depends on #30448
Depends on #34156
Depends on #34158
Depends on #34159
Depends on #34160
Depends on #34161
Depends on #34162
Depends on #34163
Depends on #34164
Depends on #34165
Depends on #34166
Depends on #34167
Depends on #34168
Depends on #34169
Depends on #34170
Depends on #34171
Depends on #34172
Depends on #34139

CC: @tscrim @fchapoton

Component: documentation

Author: Matthias Koeppe

Branch/Commit: 3b9399d

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/34157

@kwankyu kwankyu added this to the sage-9.7 milestone Jul 12, 2022
@kwankyu

This comment has been minimized.

@kwankyu

This comment has been minimized.

@kwankyu

This comment has been minimized.

@kwankyu

This comment has been minimized.

@kwankyu

This comment has been minimized.

@kwankyu

This comment has been minimized.

@kwankyu

This comment has been minimized.

@kwankyu

This comment has been minimized.

@kwankyu

This comment has been minimized.

@kwankyu

This comment has been minimized.

@kwankyu

This comment has been minimized.

@kwankyu

This comment has been minimized.

@kwankyu

This comment has been minimized.

@kwankyu

This comment has been minimized.

@kwankyu

This comment has been minimized.

@kwankyu

This comment has been minimized.

@mkoeppe
Copy link
Member

mkoeppe commented Jul 12, 2022

comment:18

What should we do with

sage/combinat/tutorial.py:20:1: RST303 Unknown directive type "todo".

Normalize all to TODO, or make the lower-case todo known to the linter?

@kwankyu
Copy link
Collaborator Author

kwankyu commented Jul 13, 2022

comment:19

Replying to @mkoeppe:

What should we do with

sage/combinat/tutorial.py:20:1: RST303 Unknown directive type "todo".

(1) Normalize all to TODO, or
(2) make the lower-case todo known to the linter?

According to

https://doc.sagemath.org/html/en/developer/coding_basics.html#sage-documentation-style

TODO is preferred in sage. But I think todo should be at least known to the linter since sphinx doesn't care the case. So I am +1 to (2).

@jhpalmieri
Copy link
Member

comment:20

Replying to @mkoeppe:

What should we do with

sage/combinat/tutorial.py:20:1: RST303 Unknown directive type "todo".

Normalize all to TODO, or make the lower-case todo known to the linter?

Probably both. People will write new code by imitating what they see in the old code, so the more we match the guidelines, the better.

(This is another case like the blank lines between list items where I don't see the point in having a strict guideline. In this case we actually have one in place, so we should follow it.)

@mkoeppe
Copy link
Member

mkoeppe commented Jul 14, 2022

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 14, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

f2b44c5rst fixes in rings and interacts
4950d2bfix one detail
e713cecMerge #34169

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 14, 2022

Commit: e713cec

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 15, 2022

Changed commit from e713cec to 48ad149

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 15, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

b37c1derst fixes in geometry matroids modules
918dfcdMerge branch 't/30448/public/30448' into t/34167/34167
ecd5e1atrac 34167: add MODULEAUTHOR, autofunction to the list of known directives
1c7f79aMerge #34167
8f13a5arst fixes in interfaces/
c79ff66fix details
48ad149Merge #34163

@mkoeppe
Copy link
Member

mkoeppe commented Jul 15, 2022

comment:24

To test with the bugfix release of the linter, regenerate the toxenv using
./sage -tox -r -e rst

@mkoeppe
Copy link
Member

mkoeppe commented Jul 16, 2022

comment:25

Remaining failures:

sage/combinat/parallelogram_polyomino.py:430:1: RST213 Inline emphasis start-string without end-string.
sage/combinat/parallelogram_polyomino.py:430:1: RST210 Inline strong start-string without end-string.
sage/combinat/counting.py:2:1: RST399 Document or section may not begin with a transition.
sage/combinat/designs/database.py:20:1: RST202 Bullet list ends without a blank line; unexpected unindent.
sage/combinat/designs/database.py:25:1: RST202 Bullet list ends without a blank line; unexpected unindent.
sage/combinat/designs/database.py:28:1: RST202 Bullet list ends without a blank line; unexpected unindent.
sage/combinat/designs/database.py:31:1: RST202 Bullet list ends without a blank line; unexpected unindent.
sage/combinat/designs/database.py:37:1: RST202 Bullet list ends without a blank line; unexpected unindent.
sage/doctest/sources.py:765:1: RST214 Inline literal start-string without end-string.
sage/doctest/sources.py:765:1: RST214 Inline literal start-string without end-string.
sage/repl/interpreter.py:465:1: RST303 Unknown directive type "attribute".
sage/graphs/graph_plot.py:50:1: RST299 The "csv-table" directive requires content; none supplied.

@slel
Copy link
Member

slel commented Aug 8, 2022

comment:47

Please rebase.

@mkoeppe
Copy link
Member

mkoeppe commented Aug 8, 2022

comment:48

No need, it merges cleanly with 9.7.beta8 when done manually

@vbraun
Copy link
Member

vbraun commented Aug 29, 2022

Changed branch from u/mkoeppe/meta_ticket__fix_docstring_markups to 3b9399d

@vbraun vbraun closed this as completed in a965858 Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants