Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem translating Fricas special function ellipticF to Sagemath #34186

Closed
nasser1 opened this issue Jul 15, 2022 · 13 comments
Closed

Problem translating Fricas special function ellipticF to Sagemath #34186

nasser1 opened this issue Jul 15, 2022 · 13 comments

Comments

@nasser1
Copy link

nasser1 commented Jul 15, 2022

For reference: #34058

There is still an issue with translation of Fricas special functions to Sagemath.

Using sagemath 9.7 beta 5, Fricas returns antiderivative which has ellipticF but this remains as is at Sagemath. But Sagemath has no such special function. It should be elliptic_f


>./sage
┌────────────────────────────────────────────────────────────────────┐
│ SageMath version 9.7.beta5, Release Date: 2022-07-10               │
│ Using Python 3.10.5. Type "help()" for help.                       │
└────────────────────────────────────────────────────────────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ Warning: this is a prerelease version, and it may be unstable.     ┃
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
sage: var('a b c x d')
(a, b, c, x, d)
sage: integrate((b*x^2+a)^(1/2)*(d*x^2+c)^(1/2),x, algorithm="fricas")
1/3*((b*d^2*x^2 + b*c*d + a*d^2)*sqrt(b*x^2 + a)*sqrt(d*x^2 + c)*sqrt(b*d)*sqrt(-c/d) - (b^2*c^3 + a*b*c^2*d + 2*a*b*c*d^2)*x*ellipticF(sqrt(-c/d)/x, a*d/(b*c)) + (b^2*c^3 + a*b*c^2*d)*x*elliptic_e(arcsin(sqrt(-c/d)/x), a*d/(b*c)))/(sqrt(b*d)*b*d^2*x*sqrt(-c/d))
sage: ?ellipticF
Object `ellipticF` not found.

Thank you
--Nasser

CC: @mantepse @fchapoton

Component: interfaces

Keywords: fricas

Author: Martin Rubey

Branch/Commit: c89110a

Reviewer: Frédéric Chapoton, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34186

@nasser1 nasser1 added this to the sage-9.7 milestone Jul 15, 2022
@mantepse
Copy link
Collaborator

Changed keywords from fricas intergate symbolic to fricas

@mantepse
Copy link
Collaborator

@mantepse
Copy link
Collaborator

Commit: c89110a

@mantepse
Copy link
Collaborator

Author: Martin Rubey

@mantepse
Copy link
Collaborator

New commits:

c89110aadd translation for ellipticF

@nasser1
Copy link
Author

nasser1 commented Jul 18, 2022

comment:4

How does one test the above fix? Does one need to wait for sagemath 9.7 beta 6? I know nothing about using github. I only know how to download the zip file and build sagemath from it.

@mantepse
Copy link
Collaborator

comment:5

I am afraid that without git it is not possible to test it. But using git and got trac is not hard, see the developers guide.

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:7

I cannot test and will not be able to. If tests pass with and without fricas, you can set to positive on my behalf.

@fchapoton
Copy link
Contributor

comment:8

ping ?

@tscrim
Copy link
Collaborator

tscrim commented Aug 29, 2022

comment:9

I tested it both ways. LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Aug 29, 2022

Changed reviewer from Frédéric Chapoton to Frédéric Chapoton, Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Aug 30, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants