Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove imports from sage.rings.all in sage.schemes #34190

Closed
mkoeppe opened this issue Jul 16, 2022 · 14 comments
Closed

Remove imports from sage.rings.all in sage.schemes #34190

mkoeppe opened this issue Jul 16, 2022 · 14 comments

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Jul 16, 2022

Part of Meta-ticket #34201.

CC: @nbruin

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: cc5d6da

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/34190

@mkoeppe mkoeppe added this to the sage-9.7 milestone Jul 16, 2022
@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 24, 2022

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2022

Commit: 0a5c6f8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

0a5c6f8git grep -l 'all import' src/sage/schemes | xargs sed -i.bak 's/[.]all import Rings$/.rings import Rings/'

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2022

Changed commit from 0a5c6f8 to a68b701

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

a68b701src/sage/schemes: Remove some .all imports

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

cc5d6dasrc/sage/schemes: Remove some more .all imports

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2022

Changed commit from a68b701 to cc5d6da

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 24, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 24, 2022

comment:6

Green bots, ready for review

@mkoeppe

This comment has been minimized.

@kwankyu
Copy link
Collaborator

kwankyu commented Aug 27, 2022

comment:7

LGTM.

@kwankyu
Copy link
Collaborator

kwankyu commented Aug 27, 2022

Reviewer: Kwankyu Lee

@mkoeppe
Copy link
Member Author

mkoeppe commented Aug 27, 2022

comment:8

Thank you!

@vbraun
Copy link
Member

vbraun commented Aug 30, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants