Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox -e docker-...-incremental #34228

Closed
mkoeppe opened this issue Jul 26, 2022 · 30 comments
Closed

tox -e docker-...-incremental #34228

mkoeppe opened this issue Jul 26, 2022 · 30 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 26, 2022

This does an incremental build of Sage on top of a prebuilt image published at ghcr.io (https://github.com/orgs/sagemath/packages?tab=packages)

For example:

$ tox -e docker-fedora-31-standard-incremental

CC: @dimpase @kliem

Component: porting

Author: Matthias Koeppe

Branch/Commit: 85ce9a6

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/34228

@mkoeppe mkoeppe added this to the sage-9.7 milestone Jul 26, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 26, 2022

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 26, 2022

Commit: a9eaae5

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 26, 2022

New commits:

a9eaae5tox.ini, build/bin/write-dockerfile.sh: Add 'tox -e docker-...-incremental'

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 26, 2022

Author: Matthias Koeppe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 26, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

b9bfbf9tox.ini: Add comment

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 26, 2022

Changed commit from a9eaae5 to b9bfbf9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 27, 2022

Changed commit from b9bfbf9 to 4c0d7f5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 27, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

4c0d7f5tox.ini: Use FROM_DOCKER_REPOSITORY

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 27, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

a07874dbuild/bin/write-dockerfile.sh: In incremental build, keep logs

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 27, 2022

Changed commit from 4c0d7f5 to a07874d

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 27, 2022

comment:6

Ready for review

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 28, 2022

Changed commit from a07874d to ae269d1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 28, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

ae269d1tox.ini (docker-incremental): Do not include '-incremental' in the Docker image name

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 31, 2022

comment:8

does not work with devtoolset

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 1, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

b354a38tox.ini, .github/workflows/docker.yml: Reimplement -incremental via SKIP_SYSTEM_PACKAGES
5decaddbuild/bin/write-dockerfile.sh: Do not use persistent env var PACKAGES (except on nix)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 1, 2022

Changed commit from ae269d1 to 5decadd

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 14, 2022

Changed commit from 5decadd to a90608f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 14, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

adddf8eMerge tag '9.7.beta8' into t/34228/tox__e_docker_____incremental
a90608fbuild/bin/write-dockerfile.sh: Invoke sage-package directly, do not go through ./sage

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 1, 2022

Changed commit from a90608f to 85ce9a6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 1, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

85ce9a6Merge tag '9.7.rc0' into t/34228/tox__e_docker_____incremental

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 1, 2022

comment:14

Let's get this in please

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 16, 2022

comment:15

ping

@dimpase
Copy link
Member

dimpase commented Sep 16, 2022

comment:16

sorry, can't review, docker issues on one machine I have it.

(hilariosly, another laptop, with macOS, has docker just fine, but it's misplaced somewhere in our messy house, hopefully I'll bump into it soon...)

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 16, 2022

@dimpase
Copy link
Member

dimpase commented Sep 17, 2022

comment:18

lgtm

@dimpase
Copy link
Member

dimpase commented Sep 17, 2022

Reviewer: Dima Pasechnik

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 17, 2022

comment:19

Thank you!

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 19, 2022

comment:20

Marking it as critical because a long chain of tickets depends on it

@vbraun
Copy link
Member

vbraun commented Sep 20, 2022

Changed branch from u/mkoeppe/tox__e_docker_____incremental to 85ce9a6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants